Skip to content

Remove DCO config and update PR template link#51

Merged
macohen merged 2 commits into
opensearch-project:mainfrom
noCharger:remove-dco-config-dev
Dec 21, 2022
Merged

Remove DCO config and update PR template link#51
macohen merged 2 commits into
opensearch-project:mainfrom
noCharger:remove-dco-config-dev

Conversation

@noCharger
Copy link
Copy Markdown
Collaborator

@noCharger noCharger commented Dec 21, 2022

Signed-off-by: Lingzhi Chu lingzhichu.clz@gmail.com

  1. Action failed in backport PR due to static DCO check - remove the extra dco.yml
  2. Remove knn plugin links in PR Template

Description

Since DCO is already installed for opensearch-project, remove the DCO configuration. This will resolve the issue of backport PRs not receiving signoff.

Screen Shot 2022-12-21 at 1 06 03 PM

Screen Shot 2022-12-21 at 1 12 21 PM

Issues Resolved

#55

Check List

  • All tests pass
  • Commits are signed as per the DCO using --signoff

Signed-off-by: Lingzhi Chu <lingzhichu.clz@gmail.com>
@noCharger noCharger self-assigned this Dec 21, 2022
@noCharger noCharger added Mend: configuration error Mend configuration error backport 2.x Backport to 2.x branch labels Dec 21, 2022
@mend-for-gitlite.zycloud.tk mend-for-gitlite.zycloud.tk Bot changed the title Remove DCO config Remove DCO config - autoclosed Dec 21, 2022
@mend-for-gitlite.zycloud.tk
Copy link
Copy Markdown
Contributor

✔️ This issue was automatically closed by Mend because the errors have been resolved.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 21, 2022

Codecov Report

Merging #51 (323526e) into main (dc94dbe) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #51   +/-   ##
=========================================
  Coverage     65.52%   65.52%           
  Complexity      172      172           
=========================================
  Files            29       29           
  Lines           879      879           
  Branches        119      119           
=========================================
  Hits            576      576           
  Misses          254      254           
  Partials         49       49           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@noCharger noCharger marked this pull request as ready for review December 21, 2022 22:01
@noCharger noCharger requested a review from a team December 21, 2022 22:01
Signed-off-by: Lingzhi Chu <lingzhichu.clz@gmail.com>
@noCharger noCharger force-pushed the remove-dco-config-dev branch from deab3ac to 323526e Compare December 21, 2022 22:07
@noCharger noCharger changed the title Remove DCO config - autoclosed Remove DCO config and update PR template link Dec 21, 2022
Copy link
Copy Markdown
Collaborator

@macohen macohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@macohen macohen merged commit 6ead87e into opensearch-project:main Dec 21, 2022
opensearch-trigger-bot Bot pushed a commit that referenced this pull request Dec 21, 2022
* Remove DCO config

Signed-off-by: Lingzhi Chu <lingzhichu.clz@gmail.com>

* Update templates

Signed-off-by: Lingzhi Chu <lingzhichu.clz@gmail.com>

Signed-off-by: Lingzhi Chu <lingzhichu.clz@gmail.com>
(cherry picked from commit 6ead87e)
@mingshl mingshl added the maintenance A change to add support for new versions of OpenSearch or OpenSearch Dashboards from upstream. label Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x Backport to 2.x branch maintenance A change to add support for new versions of OpenSearch or OpenSearch Dashboards from upstream. Mend: configuration error Mend configuration error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants