Skip to content

Updating README.md to talk more about Search Query & Request Transfor…#58

Merged
noCharger merged 2 commits intoopensearch-project:mainfrom
macohen:main
Dec 23, 2022
Merged

Updating README.md to talk more about Search Query & Request Transfor…#58
noCharger merged 2 commits intoopensearch-project:mainfrom
macohen:main

Conversation

@macohen
Copy link
Copy Markdown
Collaborator

@macohen macohen commented Dec 21, 2022

Signed-off-by: Mark Cohen markcoh@amazon.com

Description

Updating to reflect the future of this repository better.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…mers

Signed-off-by: Mark Cohen <markcoh@amazon.com>
@macohen macohen requested a review from a team December 21, 2022 23:28
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 21, 2022

Codecov Report

Merging #58 (cb9b589) into main (c08b676) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #58   +/-   ##
=========================================
  Coverage     65.52%   65.52%           
  Complexity      172      172           
=========================================
  Files            29       29           
  Lines           879      879           
  Branches        119      119           
=========================================
  Hits            576      576           
  Misses          254      254           
  Partials         49       49           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@noCharger noCharger added the documentation Improvements or additions to documentation label Dec 23, 2022
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Copy link
Copy Markdown
Collaborator

@noCharger noCharger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@noCharger noCharger merged commit 579f205 into opensearch-project:main Dec 23, 2022
@noCharger noCharger added the backport 2.x Backport to 2.x branch label Dec 23, 2022
@opensearch-trigger-bot
Copy link
Copy Markdown

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-58-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 579f2058eafa5ffb96c903a620b68e75d787e09c
# Push it to GitHub
git push --set-upstream origin backport/backport-58-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-58-to-2.x.

@noCharger noCharger added backport 2.x Backport to 2.x branch and removed backport 2.x Backport to 2.x branch labels Jan 4, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 4, 2023
#58)

* Updating README.md to talk more about Search Query & Request Transformers

Signed-off-by: Mark Cohen <markcoh@amazon.com>

* Update README.md

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>

Signed-off-by: Mark Cohen <markcoh@amazon.com>
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
(cherry picked from commit 579f205)
noCharger pushed a commit that referenced this pull request Jan 4, 2023
#58) (#75)

* Updating README.md to talk more about Search Query & Request Transformers

Signed-off-by: Mark Cohen <markcoh@amazon.com>

* Update README.md

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: Mark Cohen <markcoh@amazon.com>

Signed-off-by: Mark Cohen <markcoh@amazon.com>
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
(cherry picked from commit 579f205)

Co-authored-by: Mark Cohen <markcoh@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x Backport to 2.x branch documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants