Skip to content

Add config rule for auto categorizing labels#84

Merged
noCharger merged 3 commits intoopensearch-project:mainfrom
mingshl:config-auto-label
Jan 20, 2023
Merged

Add config rule for auto categorizing labels#84
noCharger merged 3 commits intoopensearch-project:mainfrom
mingshl:config-auto-label

Conversation

@mingshl
Copy link
Copy Markdown
Collaborator

@mingshl mingshl commented Jan 19, 2023

To address issue #83
Signed-off-by: Mingshi Liu mingshl@amazon.com

Signed-off-by: Mingshi Liu <mingshl@amazon.com>
@mingshl mingshl requested a review from a team January 19, 2023 00:05
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 19, 2023

Codecov Report

Merging #84 (cfeb994) into main (2308941) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #84   +/-   ##
=========================================
  Coverage     65.52%   65.52%           
  Complexity      172      172           
=========================================
  Files            29       29           
  Lines           879      879           
  Branches        119      119           
=========================================
  Hits            576      576           
  Misses          254      254           
  Partials         49       49           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Mingshi Liu <mingshl@amazon.com>
@mingshl
Copy link
Copy Markdown
Collaborator Author

mingshl commented Jan 19, 2023

@noCharger aligned to create 1 to 1 relation between label and category. modified in label to category 1:1 mapping

Copy link
Copy Markdown
Collaborator

@noCharger noCharger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the optimization! Only a few minor tweaks to make it more consistent.

Signed-off-by: Mingshi Liu <mingshl@amazon.com>
@noCharger noCharger merged commit 8ee6eb5 into opensearch-project:main Jan 20, 2023
@mingshl mingshl deleted the config-auto-label branch January 20, 2023 19:01
@noCharger noCharger added the backport 2.x Backport to 2.x branch label Jan 20, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 20, 2023
@noCharger noCharger added the maintenance A change to add support for new versions of OpenSearch or OpenSearch Dashboards from upstream. label Jan 20, 2023
@noCharger
Copy link
Copy Markdown
Collaborator

@mingshl Let's make sure all labels are created as well.

@mingshl
Copy link
Copy Markdown
Collaborator Author

mingshl commented Jan 21, 2023

@mingshl Let's make sure all labels are created as well.

still waiting for getting maintenance access to create new labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x Backport to 2.x branch maintenance A change to add support for new versions of OpenSearch or OpenSearch Dashboards from upstream.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants