Skip to content

adding Mingshi Liu as a maintainer to the repo#86

Merged
mingshl merged 1 commit intoopensearch-project:mainfrom
macohen:main
Jan 23, 2023
Merged

adding Mingshi Liu as a maintainer to the repo#86
mingshl merged 1 commit intoopensearch-project:mainfrom
macohen:main

Conversation

@macohen
Copy link
Copy Markdown
Collaborator

@macohen macohen commented Jan 23, 2023

Signed-off-by: Mark Cohen markcoh@amazon.com

Description

adds mingshl@ as a maintainer

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Mark Cohen <markcoh@amazon.com>
@macohen macohen requested a review from a team January 23, 2023 20:41
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #86 (7965997) into main (2308941) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #86   +/-   ##
=========================================
  Coverage     65.52%   65.52%           
  Complexity      172      172           
=========================================
  Files            29       29           
  Lines           879      879           
  Branches        119      119           
=========================================
  Hits            576      576           
  Misses          254      254           
  Partials         49       49           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mingshl mingshl merged commit 60f6cbb into opensearch-project:main Jan 23, 2023
@mingshl mingshl added documentation Improvements or additions to documentation backport 2.x Backport to 2.x branch labels Jan 23, 2023
@opensearch-trigger-bot
Copy link
Copy Markdown

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-86-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 60f6cbbb28c9da412225b1234066ad28fe7d2e29
# Push it to GitHub
git push --set-upstream origin backport/backport-86-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-86-to-2.x.

mingshl added a commit to mingshl/search-processor that referenced this pull request Jan 23, 2023
adding Mingshi Liu as a maintainer to the repo

(cherry picked from commit 60f6cbb)
mingshl added a commit to mingshl/search-processor that referenced this pull request Jan 23, 2023
adding Mingshi Liu as a maintainer to the repo

(cherry picked from commit 60f6cbb)
Signed-off-by: Mingshi Liu <mingshl@amazon.com>
msfroh pushed a commit that referenced this pull request Jan 24, 2023
adding Mingshi Liu as a maintainer to the repo

(cherry picked from commit 60f6cbb)
Signed-off-by: Mingshi Liu <mingshl@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x Backport to 2.x branch documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants