add feature flag for search relevance workbench#34
add feature flag for search relevance workbench#34martin-gaievski merged 3 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Fen Qin <mfenqin@amazon.com>
Signed-off-by: Fen Qin <mfenqin@amazon.com>
|
I think flag should be "enabled" by default and user needs to opt-out in case they don't want SRW |
|
@martin-gaievski @heemin32
Can you check if my understanding here is correct ? My action items on this task:
|
Yes
We should keep it as dynamic. |
Signed-off-by: Fen Qin <mfenqin@amazon.com>
|
reverse the feature flag. By defaulted, customers are opt-in the SWR. Then they can choose to opt-out SWR to use old experience. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
- Coverage 14.48% 0 -14.49%
==========================================
Files 107 0 -107
Lines 3313 0 -3313
Branches 236 0 -236
==========================================
- Hits 480 0 -480
+ Misses 2808 0 -2808
+ Partials 25 0 -25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* add feature flag for search relevance workbench Signed-off-by: Fen Qin <mfenqin@amazon.com> * add CHANGELOG.md for feature flag Signed-off-by: Fen Qin <mfenqin@amazon.com> * change defaulted value to true Signed-off-by: Fen Qin <mfenqin@amazon.com> --------- Signed-off-by: Fen Qin <mfenqin@amazon.com>


Description
Add a feature flag to by defaulted enable search relevance workbench. When dashboards read the cluster settings, it can do the access control to opt-in/opt-out user experience between old version and new version.
Issues Resolved
#33
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.