Switch to maven to download plugin snapshots#1331
Merged
peternied merged 1 commit intoopensearch-project:mainfrom Feb 16, 2023
Merged
Switch to maven to download plugin snapshots#1331peternied merged 1 commit intoopensearch-project:mainfrom
peternied merged 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Peter Nied <petern@amazon.com>
CEHENKLE
approved these changes
Feb 16, 2023
cwperks
approved these changes
Feb 16, 2023
Member
|
@peternied Should the backport 2.x label be added? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1331 +/- ##
=======================================
Coverage 71.78% 71.78%
=======================================
Files 88 88
Lines 2027 2027
Branches 274 274
=======================================
Hits 1455 1455
Misses 509 509
Partials 63 63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RyanL1997
reviewed
Feb 16, 2023
|
|
||
| - name: Rename the Plugin Files | ||
| run: mv opensearch-security-${{ inputs.plugin-version }}.zip opensearch-security.zip | ||
| - run: | |
Collaborator
There was a problem hiding this comment.
Could we add a name for this task, so that it is easy to track in the terminal. The rest looks good to me!
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 16, 2023
Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit a039441)
peternied
added a commit
that referenced
this pull request
Feb 16, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 28, 2023
Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit a039441)
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-1331-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a0394415cd0f3cefad39c4cac9f7c9d6c23a62d1
# Push it to GitHub
git push --set-upstream origin backport/backport-1331-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.xThen, create a pull request where the |
3 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Security Plugin publishing snapshots of its build through maven. Switching from the distribution build to these maven based artifacts.
Note; The security plugin does not publish these artifacts for version 1.x so this change should not be backported.
Issues Resolved
Testing
This change is tested through GitHub Actions associated with this project
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.