Skip to content

Replace legacy template with index template#1359

Merged
cliu123 merged 2 commits intoopensearch-project:mainfrom
cliu123:replace_legacy_template_with_index_template
Mar 6, 2023
Merged

Replace legacy template with index template#1359
cliu123 merged 2 commits intoopensearch-project:mainfrom
cliu123:replace_legacy_template_with_index_template

Conversation

@cliu123
Copy link
Copy Markdown
Member

@cliu123 cliu123 commented Mar 4, 2023

Description

This change replaces the legacy template with the new index template.
This PR depends on opensearch-project/security#2503, so the opensearch-project/security#2503 needs to be merged first.

Category

[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation] Enhancement

Why these changes are required?

The new index template is the replacement of the legacy template.

Issues Resolved

#1222

Testing

UT & IT & Manual Testing

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Chang Liu <lc12251109@gmail.com>
@cliu123 cliu123 force-pushed the replace_legacy_template_with_index_template branch from aedfa1a to 3bd3fc7 Compare March 4, 2023 02:30
Signed-off-by: Chang Liu <lc12251109@gmail.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 4, 2023

Codecov Report

Merging #1359 (23d4fc3) into main (293aed8) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #1359   +/-   ##
=======================================
  Coverage   71.78%   71.78%           
=======================================
  Files          88       88           
  Lines        2027     2027           
  Branches      269      269           
=======================================
  Hits         1455     1455           
  Misses        509      509           
  Partials       63       63           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cliu123 cliu123 requested a review from a team March 4, 2023 08:08
@cliu123 cliu123 added backport 1.3 backport 2.0 backport to 2.0 branch backport 2.x backport to 2.x branch backport 1.x backport to 1.x branch backport 1.2 backport to 1.2 branch backport 2.1 backport 2.1 branch backport 1.0 backport 1.1 backport 2.2 backport to 2.2 branch backport 2.3 backport to 2.3 branch backport 2.4 backport to 2.4 branch backport 2.5 backport to 2.5 branch backport 2.6 backport to 2.6 branch backport opendistro-1.13 Backport to opendistro-1.13 branch backport opendistro-1.11 Backport to opendistro-1.11 branch labels Mar 6, 2023
@stephen-crawford stephen-crawford removed backport 2.0 backport to 2.0 branch backport 1.2 backport to 1.2 branch backport 2.1 backport 2.1 branch labels Mar 6, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 6, 2023
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit b69a364)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 6, 2023
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit b69a364)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 6, 2023
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit b69a364)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 6, 2023
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit b69a364)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 6, 2023
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit b69a364)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 6, 2023
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit b69a364)
@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

The backport to opendistro-1.13 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-opendistro-1.13 opendistro-1.13
# Navigate to the new working tree
cd .worktrees/backport-opendistro-1.13
# Create a new branch
git switch --create backport/backport-1359-to-opendistro-1.13
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b69a364ebb70e19dedb4dbf21b1764b47a49f250
# Push it to GitHub
git push --set-upstream origin backport/backport-1359-to-opendistro-1.13
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-opendistro-1.13

Then, create a pull request where the base branch is opendistro-1.13 and the compare/head branch is backport/backport-1359-to-opendistro-1.13.

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

The backport to opendistro-1.11 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-opendistro-1.11 opendistro-1.11
# Navigate to the new working tree
cd .worktrees/backport-opendistro-1.11
# Create a new branch
git switch --create backport/backport-1359-to-opendistro-1.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b69a364ebb70e19dedb4dbf21b1764b47a49f250
# Push it to GitHub
git push --set-upstream origin backport/backport-1359-to-opendistro-1.11
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-opendistro-1.11

Then, create a pull request where the base branch is opendistro-1.11 and the compare/head branch is backport/backport-1359-to-opendistro-1.11.

cliu123 added a commit that referenced this pull request Mar 7, 2023
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit b69a364)

Co-authored-by: Chang Liu <lc12251109@gmail.com>
cliu123 added a commit that referenced this pull request Mar 7, 2023
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit b69a364)

Co-authored-by: Chang Liu <lc12251109@gmail.com>
RyanL1997 pushed a commit that referenced this pull request Mar 9, 2023
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit b69a364)
peternied pushed a commit that referenced this pull request Mar 22, 2023
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit b69a364)

Co-authored-by: Chang Liu <lc12251109@gmail.com>
peternied pushed a commit that referenced this pull request Mar 22, 2023
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit b69a364)

Co-authored-by: Chang Liu <lc12251109@gmail.com>
@cwperks cwperks added the backport opendistro-1.12 Backport to opendistro-1.12 branch label May 25, 2023
@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

The backport to opendistro-1.12 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-opendistro-1.12 opendistro-1.12
# Navigate to the new working tree
cd .worktrees/backport-opendistro-1.12
# Create a new branch
git switch --create backport/backport-1359-to-opendistro-1.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b69a364ebb70e19dedb4dbf21b1764b47a49f250
# Push it to GitHub
git push --set-upstream origin backport/backport-1359-to-opendistro-1.12
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-opendistro-1.12

Then, create a pull request where the base branch is opendistro-1.12 and the compare/head branch is backport/backport-1359-to-opendistro-1.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport opendistro-1.11 Backport to opendistro-1.11 branch backport opendistro-1.12 Backport to opendistro-1.12 branch backport opendistro-1.13 Backport to opendistro-1.13 branch backport 1.x backport to 1.x branch backport 1.0 backport 1.1 backport 1.2 backport to 1.2 branch backport 1.3 backport 2.x backport to 2.x branch backport 2.0 backport to 2.0 branch backport 2.1 backport 2.1 branch backport 2.2 backport to 2.2 branch backport 2.3 backport to 2.3 branch backport 2.4 backport to 2.4 branch backport 2.5 backport to 2.5 branch backport 2.6 backport to 2.6 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants