Skip to content

Explicitly pass basePath: false in jwt_auth.test.ts#1553

Closed
cwperks wants to merge 5 commits intoopensearch-project:mainfrom
cwperks:fix-jwt-auth-test
Closed

Explicitly pass basePath: false in jwt_auth.test.ts#1553
cwperks wants to merge 5 commits intoopensearch-project:mainfrom
cwperks:fix-jwt-auth-test

Conversation

@cwperks
Copy link
Copy Markdown
Member

@cwperks cwperks commented Aug 14, 2023

Description

This PR explicitly sets basePath to false in jwt_auth.test.ts to ensure that the test does not run with a basePath

Fixes CI errors seen in: #1550

I'm am looking more into osdTestServer.getRootWithSettings to see why the default is not being picked up: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/9253a372004ae108afad01cdc41d36a9ceccd1ff/src/core/test_helpers/osd_server.ts#L75-L104

Category

[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]

Test fix

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 14, 2023

Codecov Report

Merging #1553 (1518899) into main (20ba268) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1553   +/-   ##
=======================================
  Coverage   66.06%   66.06%           
=======================================
  Files          93       93           
  Lines        2328     2328           
  Branches      310      310           
=======================================
  Hits         1538     1538           
  Misses        722      722           
  Partials       68       68           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants