Skip to content

[Backport 1.3] Split up a value into multiple cookie payload#1831

Merged
DarshitChanpura merged 3 commits intoopensearch-project:1.3from
cwperks:backport-cookie-splitter-1.3
Mar 19, 2024
Merged

[Backport 1.3] Split up a value into multiple cookie payload#1831
DarshitChanpura merged 3 commits intoopensearch-project:1.3from
cwperks:backport-cookie-splitter-1.3

Conversation

@cwperks
Copy link
Copy Markdown
Member

@cwperks cwperks commented Mar 18, 2024

Backport #1352 to 1.3

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.48%. Comparing base (81910ea) to head (5c997ed).

Additional details and impacted files
@@           Coverage Diff           @@
##              1.3    #1831   +/-   ##
=======================================
  Coverage   72.48%   72.48%           
=======================================
  Files          88       88           
  Lines        1926     1926           
  Branches      246      251    +5     
=======================================
  Hits         1396     1396           
  Misses        474      474           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Copy link
Copy Markdown
Member Author

cwperks commented Mar 19, 2024

@derek-ho The start-opensearch script for 1.3 is failing with this error:

./opensearch-1.3.15-SNAPSHOT/plugins/opensearch-security/tools/install_demo_configuration.sh: illegal option -- t

Can the logic be updated not to pass that arg in for 1.X?

Reference: https://github.com/opensearch-project/security-dashboards-plugin/actions/runs/8344262960/job/22836324597?pr=1831#step:11:316

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Copy link
Copy Markdown
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested to use old workflow not on main branch until I can generalize it enough. Since -t was introduced in 2.12 we may need to do a version check

@DarshitChanpura DarshitChanpura merged commit 6e581cc into opensearch-project:1.3 Mar 19, 2024
DarshitChanpura pushed a commit to DarshitChanpura/security-dashboards-plugin that referenced this pull request Mar 20, 2024
…rch-project#1831)

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit 6e581cc)
DarshitChanpura added a commit that referenced this pull request Mar 20, 2024
…ent (#1752)

* [1.3] Add 1.3.14 release notes (#1690)

Signed-off-by: Derek Ho <dxho@amazon.com>

* Increment version to 1.3.15.0 (#1698)

Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>
(cherry picked from commit 81910ea)

* [Backport 1.3] Split up a value into multiple cookie payload (#1831)

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit 6e581cc)

---------

Signed-off-by: Derek Ho <dxho@amazon.com>
Co-authored-by: Derek Ho <dxho@amazon.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Craig Perkins <cwperx@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants