Skip to content

[Backport 2.x] Add husky pre commit and lint files#1859

Merged
DarshitChanpura merged 2 commits intoopensearch-project:2.xfrom
derek-ho:husky-back
Apr 2, 2024
Merged

[Backport 2.x] Add husky pre commit and lint files#1859
DarshitChanpura merged 2 commits intoopensearch-project:2.xfrom
derek-ho:husky-back

Conversation

@derek-ho
Copy link
Copy Markdown
Collaborator

@derek-ho derek-ho commented Mar 28, 2024

Description

Backport of the PR to add husky pre commit hook linting and lints files according to no unused imports.

Category

Maintenance

Why these changes are required?

Clean up code, reduce dev overhead

What is the old behavior before changes and new behavior after changes?

No longer need to run yarn lint:es --fix with each commit

Issues Resolved

Backport of #1851

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
@derek-ho derek-ho marked this pull request as ready for review March 28, 2024 16:18
@DarshitChanpura DarshitChanpura merged commit f2e44ba into opensearch-project:2.x Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants