Use preferred_tenants from dashboardinfo when resolving tenant#2391
Open
itsmevichu wants to merge 1 commit intoopensearch-project:mainfrom
Open
Use preferred_tenants from dashboardinfo when resolving tenant#2391itsmevichu wants to merge 1 commit intoopensearch-project:mainfrom
preferred_tenants from dashboardinfo when resolving tenant#2391itsmevichu wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Vishnutheep B <vishnutheep@gmail.com>
itsmevichu
requested review from
DarshitChanpura,
RyanL1997,
cwperks and
derek-ho
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2391 +/- ##
=======================================
Coverage 71.59% 71.59%
=======================================
Files 101 101
Lines 3010 3010
Branches 529 511 -18
=======================================
Hits 2155 2155
Misses 699 699
Partials 156 156 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
FYI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related PR - opensearch-project/security#5986
This PR resolves
preferred_tenantsfrom the DashboardInfo API; if unavailable, it falls back to the config file. This enabes dynamic configuration ofpreferred_tenantsCategory
Enhancement
Why these changes are required?
This PR resolves
preferred_tenantsfrom the DashboardInfo API; if unavailable, it falls back to the config file. This enabes dynamic configuration ofpreferred_tenantsWhat is the old behavior before changes and new behavior after changes?
preferred_tenants are read from config file, and requires a restart to configure this property.
Issues Resolved
Resolves opensearch-project/security#5969 (from opensearch-project/security)
Testing
I have performed manual testing and added unit tests.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.