Skip to content

Replaces sasslint to stylelint to conform to changes in core dashboards#933

Closed
DarshitChanpura wants to merge 1 commit intoopensearch-project:mainfrom
DarshitChanpura:sasslint-to-stylelint
Closed

Replaces sasslint to stylelint to conform to changes in core dashboards#933
DarshitChanpura wants to merge 1 commit intoopensearch-project:mainfrom
DarshitChanpura:sasslint-to-stylelint

Conversation

@DarshitChanpura
Copy link
Copy Markdown
Member

Testing

run yarn lint. It should pass without any errors

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
@DarshitChanpura DarshitChanpura requested a review from a team April 6, 2022 02:42
@peternied
Copy link
Copy Markdown
Member

@DarshitChanpura The CI checks are failing because of Error: Cannot find module '/home/runner/work/security-dashboards-plugin/security-dashboards-plugin/OpenSearch-Dashboards/scripts/stylelint' is this something that you can fix independent of moving to the new dashboard version?

@DarshitChanpura
Copy link
Copy Markdown
Member Author

@DarshitChanpura The CI checks are failing because of Error: Cannot find module '/home/runner/work/security-dashboards-plugin/security-dashboards-plugin/OpenSearch-Dashboards/scripts/stylelint' is this something that you can fix independent of moving to the new dashboard version?

Good Point! I think I will have to merge these changes in version bump PR and move forward from there

@DarshitChanpura
Copy link
Copy Markdown
Member Author

Closing this PR now as these changes are covered in #928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants