[Backport 1.x] Username validation for special characters (#2277)#2320
Merged
[Backport 1.x] Username validation for special characters (#2277)#2320
Conversation
* Only prevent user creation on colon characters, separate out tests Signed-off-by: Rutuja Surve <rutuja@amazon.com> Signed-off-by: Rutuja Surve <110013621+rutuja-amazon@users.noreply.github.com> Signed-off-by: Peter Nied <petern@amazon.com> Co-authored-by: Peter Nied <petern@amazon.com> (cherry picked from commit efbc48b)
Signed-off-by: Peter Nied <petern@amazon.com>
Member
Author
|
Looks like this needs to wait on a rebase where the install workflow has been fixed. |
peternied
commented
Dec 13, 2022
Member
Author
peternied
left a comment
peternied
left a comment
There was a problem hiding this comment.
I've reviewed the failures in the 1.x branch, no build issues, just intermittent test failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Username validation for special characters (#2277)
Signed-off-by: Rutuja Surve rutuja@amazon.com
Signed-off-by: Rutuja Surve 110013621+rutuja-amazon@users.noreply.github.com
Signed-off-by: Peter Nied petern@amazon.com
Co-authored-by: Peter Nied petern@amazon.com
(cherry picked from commit efbc48b)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.