[Backport 1.1] Username validation for special characters (#2277)

[rutuja-amazon]

Description

Username validation for special characters (#2277)

• Only prevent user creation on colon characters, separate out tests

Signed-off-by: Rutuja Surve rutuja@amazon.com
Signed-off-by: Rutuja Surve 110013621+rutuja-amazon@users.noreply.github.com
Signed-off-by: Peter Nied petern@amazon.com
Co-authored-by: Peter Nied petern@amazon.com (cherry picked from commit efbc48b)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[stephen-crawford]

Hi @rutuja-amazon, I saw that there was some issues with this backport and the 1.0 one. I just wanted to mention that unless you have an interest in contributing to these older versions for your own sake (which is great), you did not need to feel obligated to backport these last two. In general, we backport to the last minor of all supported majors so in this case you already covered the normal backporting with your backport to 1.3, 2.4, 2.x (1.x is also sometimes a target but since there is not going to be a 1.4 it is more a habit thing than a necessity).

[peternied]

Failed to execute goal on project opensearch-security: Could not resolve dependencies for project org.opensearch:opensearch-security:jar:1.1.0.0-SNAPSHOT: The following artifacts could not be resolved: org.opensearch.plugin:transport-netty4-client:jar:1.1.0-SNAPSHOT, org.opensearch:opensearch:jar:1.1.0-SNAPSHOT, org.opensearch.client:opensearch-rest-high-level-client:jar:1.1.0-SNAPSHOT: Could not find artifact org.opensearch.plugin:transport-netty4-client:jar:1.1.0-SNAPSHOT -> [Help 1]

Please look into this failure

[peternied]

@rutuja-amazon I haven't seen updates for a while, I'm going to close out this pull request, please let me know if you'd like me to reopen it.

[rutuja-amazon]

Hi @peternied we can re-open the PR , I'm not seeing the option to re-open.

[RyanL1997]

Seems like we are still facing the issue of missing artifact for netty on this branch (https://github.com/opensearch-project/security/actions/runs/4447793346/jobs/7809761114?pr=2331#step:8:1119):

[INFO] ------------------------------------------------------------------------
Error:  Failed to execute goal on project opensearch-security: Could not resolve dependencies for project org.opensearch:opensearch-security:jar:1.1.0.0-SNAPSHOT: The following artifacts could not be resolved: org.opensearch.plugin:transport-netty4-client:jar:1.1.0-SNAPSHOT, org.opensearch:opensearch:jar:1.1.0-SNAPSHOT, org.opensearch.client:opensearch-rest-high-level-client:jar:1.1.0-SNAPSHOT: Could not find artifact org.opensearch.plugin:transport-netty4-client:jar:1.1.0-SNAPSHOT -> [Help 1]
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:  
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
Error: Process completed with exit code 1.

[github-advanced-security]

You have successfully added a new CodeQL configuration .github/workflows/ci.yml:build. As part of the setup process, we have scanned this repository and found 15 existing alerts. Please check the repository Security tab to see all alerts.

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (1.1@d725b9e). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@          Coverage Diff           @@
##             1.1    #2331   +/-   ##
======================================
  Coverage       ?   64.92%           
  Complexity     ?     3234           
======================================
  Files          ?      247           
  Lines          ?    17348           
  Branches       ?     3076           
======================================
  Hits           ?    11263           
  Misses         ?     4528           
  Partials       ?     1557           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.