Add backend filtering for legacy internal user and service accounts#2786
Merged
stephen-crawford merged 44 commits intoopensearch-project:mainfrom Sep 22, 2023
Conversation
Signed-off-by: scosta <samuel.costa@eliatra.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
src/main/java/org/opensearch/security/dlic/rest/api/InternalUsersApiAction.java
Show resolved
Hide resolved
src/main/java/org/opensearch/security/dlic/rest/api/InternalUsersApiAction.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/security/dlic/rest/api/UserApiTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com> Signed-off-by: Sam <128482925+samuelcostae@users.noreply.github.com>
…ersApiAction.java Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com> Signed-off-by: Sam <128482925+samuelcostae@users.noreply.github.com>
Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com> Signed-off-by: Sam <128482925+samuelcostae@users.noreply.github.com>
Signed-off-by: scosta <samuel.costa@eliatra.com>
Signed-off-by: scosta <samuel.costa@eliatra.com>
Signed-off-by: scosta <samuel.costa@eliatra.com>
Contributor
Author
|
@DarshitChanpura I had to a good bit of refactoring as I noticed that before, the beahviour in the PR was returning only the list of names of the accounts of the specified type, but the existing implementations on internalUsersAPI return the full account details. |
samuelcostae
commented
May 30, 2023
src/main/java/org/opensearch/security/dlic/rest/api/InternalUsersApiAction.java
Outdated
Show resolved
Hide resolved
samuelcostae
commented
May 30, 2023
samuelcostae
commented
May 30, 2023
stephen-crawford
changed the title
Contributor
stephen-crawford
left a comment
stephen-crawford
left a comment
There was a problem hiding this comment.
Overall looks good to me. I left a comment about tests, but I believe this should ready for final review.
stephen-crawford
requested review from
RyanL1997,
cliu123,
cwperks,
davidlago,
peternied,
reta and
willyborankin
as code owners
Contributor
|
@samuelcostae could you rebase against main and resolve any conflicts. |
Signed-off-by: Sam <128482925+samuelcostae@users.noreply.github.com>
Member
|
@samuelcostae Please let us know if you would require any help to move this along. |
Member
|
@samuelcostae Thanks for the updates - sorry its taken a little bit to circle back around to this pull requests. |
# Conflicts: # src/main/java/org/opensearch/security/dlic/rest/api/InternalUsersApiAction.java
Signed-off-by: Sam <samuel.costa@eliatra.com>
Signed-off-by: Sam <samuel.costa@eliatra.com>
Contributor
|
This is associated with #2704 |
peternied
reviewed
Sep 19, 2023
src/main/java/org/opensearch/security/dlic/rest/api/InternalUsersApiAction.java
Outdated
Show resolved
Hide resolved
peternied
reviewed
Sep 19, 2023
Signed-off-by: Sam <samuel.costa@eliatra.com>
Member
DarshitChanpura
left a comment
DarshitChanpura
left a comment
There was a problem hiding this comment.
Looks close. Final two comments.
peternied
reviewed
Sep 20, 2023
Member
peternied
left a comment
peternied
left a comment
There was a problem hiding this comment.
Last blocker in my mind is the structure of the UserService code, please iterate on @DarshitChanpura suggestion to slim down that code.
Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com> Signed-off-by: Sam <128482925+samuelcostae@users.noreply.github.com>
Signed-off-by: Sam <samuel.costa@eliatra.com>
Signed-off-by: Sam <samuel.costa@eliatra.com>
samuelcostae
commented
Sep 20, 2023
peternied
reviewed
Sep 20, 2023
src/main/java/org/opensearch/security/dlic/rest/api/InternalUsersApiAction.java
Outdated
Show resolved
Hide resolved
peternied
reviewed
Sep 20, 2023
Member
peternied
left a comment
peternied
left a comment
There was a problem hiding this comment.
Adding some feedback about the new unit tests - really close.
src/test/java/org/opensearch/security/UserServiceUnitTests.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/security/UserServiceUnitTests.java
Outdated
Show resolved
Hide resolved
peternied
reviewed
Sep 21, 2023
src/main/java/org/opensearch/security/dlic/rest/api/InternalUsersApiAction.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/security/dlic/rest/api/UserApiTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/security/dlic/rest/api/InternalUsersApiAction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sam <samuel.costa@eliatra.com>
Signed-off-by: Sam <samuel.costa@eliatra.com>
Signed-off-by: Sam <samuel.costa@eliatra.com>
samuelcostae
commented
Sep 22, 2023
src/main/java/org/opensearch/security/dlic/rest/api/InternalUsersApiAction.java
Show resolved
Hide resolved
peternied
approved these changes
Sep 22, 2023
src/main/java/org/opensearch/security/dlic/rest/api/InternalUsersApiAction.java
Show resolved
Hide resolved
Member
|
@scrawfor99 Could you take another look? |
stephen-crawford
approved these changes
Sep 22, 2023
Contributor
stephen-crawford
left a comment
stephen-crawford
left a comment
There was a problem hiding this comment.
Great job Sam :)
RyanL1997
added a commit
to RyanL1997/security
that referenced
this pull request
Nov 2, 2023
Signed-off-by: Ryan Liang <jiallian@amazon.com>
This was referenced Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update UserAPIAction to Filter internal accounts and Service accounts.
Dashboards Plugin changes via PR opensearch-project/security-dashboards-plugin#1502
Issues Resolved
Testing
Unit Tests created
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.