Limit service account permission#3607
Merged
DarshitChanpura merged 24 commits intoopensearch-project:mainfrom Oct 31, 2023
Merged
Limit service account permission#3607DarshitChanpura merged 24 commits intoopensearch-project:mainfrom
DarshitChanpura merged 24 commits intoopensearch-project:mainfrom
Conversation
peternied
reviewed
Oct 26, 2023
src/main/java/org/opensearch/security/privileges/PrivilegesEvaluator.java
Outdated
Show resolved
Hide resolved
RyanL1997
commented
Oct 26, 2023
cwperks
reviewed
Oct 27, 2023
src/main/java/org/opensearch/security/privileges/SecurityIndexAccessEvaluator.java
Show resolved
Hide resolved
peternied
reviewed
Oct 27, 2023
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
e270d77 to
691b347
Compare
Signed-off-by: Ryan Liang <jiallian@amazon.com>
peternied
reviewed
Oct 27, 2023
src/integrationTest/java/org/opensearch/security/http/ServiceAccountAuthenticationTest.java
Outdated
Show resolved
Hide resolved
peternied
reviewed
Oct 27, 2023
src/integrationTest/java/org/opensearch/security/http/ServiceAccountAuthenticationTest.java
Outdated
Show resolved
Hide resolved
peternied
reviewed
Oct 27, 2023
src/integrationTest/java/org/opensearch/security/http/ServiceAccountAuthenticationTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Liang <jiallian@amazon.com>
1c8fafe to
1dc296b
Compare
…tem indices and regular indices Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
src/integrationTest/java/org/opensearch/security/http/ServiceAccountAuthenticationTest.java
Outdated
Show resolved
Hide resolved
src/integrationTest/java/org/opensearch/security/http/ServiceAccountAuthenticationTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/security/privileges/PrivilegesEvaluator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/security/privileges/SecurityIndexAccessEvaluator.java
Outdated
Show resolved
Hide resolved
peternied
reviewed
Oct 30, 2023
src/integrationTest/java/org/opensearch/security/http/ServiceAccountAuthenticationTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
cwperks
reviewed
Oct 30, 2023
src/integrationTest/java/org/opensearch/security/http/ServiceAccountAuthenticationTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/security/privileges/SecurityIndexAccessEvaluator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Liang <jiallian@amazon.com>
src/main/java/org/opensearch/security/privileges/SecurityIndexAccessEvaluator.java
Outdated
Show resolved
Hide resolved
peternied
reviewed
Oct 30, 2023
src/integrationTest/java/org/opensearch/security/http/ServiceAccountAuthenticationTest.java
Outdated
Show resolved
Hide resolved
src/integrationTest/java/org/opensearch/security/http/ServiceAccountAuthenticationTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Liang <jiallian@amazon.com>
peternied
approved these changes
Oct 31, 2023
DarshitChanpura
approved these changes
Oct 31, 2023
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-3607-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d10475cbf0cc8ccdf959964c5d30777ee72e7bcc
# Push it to GitHub
git push --set-upstream origin backport/backport-3607-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.xThen, create a pull request where the |
8 tasks
RyanL1997
added a commit
to RyanL1997/security
that referenced
this pull request
Nov 2, 2023
…ject#3607) Signed-off-by: Ryan Liang <jiallian@amazon.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Limit service account permission
Enhancement
Issues Resolved
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.