Update to Gradle 8.4#3638
Merged
peternied merged 2 commits intoopensearch-project:mainfrom Nov 2, 2023
Merged
Conversation
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta
requested review from
DarshitChanpura,
RyanL1997,
cliu123,
cwperks,
davidlago,
peternied,
stephen-crawford and
willyborankin
as code owners
95 tasks
cwperks
previously approved these changes
Nov 2, 2023
peternied
suggested changes
Nov 2, 2023
Member
peternied
left a comment
peternied
left a comment
There was a problem hiding this comment.
This is the point where I'd normally ask if could you also update the bwc-test directory. However, I've got what I think is a better offer, want to merge [1] this change that removes the separate gradle install entirely?
- [1] reta#2
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Collaborator
Author
Uh ... I am always forgetting about this one :( We could do 2 step: merge this and than your pull request, wdyt? thank you |
DarshitChanpura
approved these changes
Nov 2, 2023
Member
DarshitChanpura
left a comment
DarshitChanpura
left a comment
There was a problem hiding this comment.
I'm fine moving forward either way.
peternied
approved these changes
Nov 2, 2023
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-3638-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5de968656d409c8bb0da23ad06f8308b0c9b1443
# Push it to GitHub
git push --set-upstream origin backport/backport-3638-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.xThen, create a pull request where the |
reta
added a commit
to reta/security
that referenced
this pull request
Nov 2, 2023
Signed-off-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit 5de9686)
reta
added a commit
to reta/security
that referenced
this pull request
Nov 2, 2023
Signed-off-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit 5de9686) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
peternied
pushed a commit
that referenced
this pull request
Nov 2, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update to Gradle 8.4
Issues Resolved
Testing
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.