Backport/backport 3602 to 2.x#3862
Merged
stephen-crawford merged 2 commits intoopensearch-project:2.xfrom Dec 19, 2023
Merged
Conversation
MaciejMierzwa
force-pushed
the
backport/backport-3602-to-2.x
branch
from
4962695 to
3679d43
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #3862 +/- ##
============================================
+ Coverage 65.00% 65.06% +0.05%
- Complexity 3732 3734 +2
============================================
Files 297 297
Lines 21000 21000
Branches 3439 3439
============================================
+ Hits 13652 13663 +11
+ Misses 5644 5634 -10
+ Partials 1704 1703 -1 |
Search operation test flakiness fix - opensearch-project#3426 - opensearch-project#2141 - opensearch-project#2169 Similar to this task: opensearch-project#1917 From what I've noticed some logs are duplicated on faster machines. During test creation audit logging results were added based on actual results produced by tests. Now if there are slower moments where logging produces non-duplicated logs, those were marked as failed. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). --------- Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com> Signed-off-by: MaciejMierzwa <dev.maciej.mierzwa@gmail.com> (cherry picked from commit 9da4a78) Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
MaciejMierzwa
force-pushed
the
backport/backport-3602-to-2.x
branch
from
3679d43 to
e0eefae
Compare
MaciejMierzwa
requested review from
DarshitChanpura,
RyanL1997,
cliu123,
cwperks,
davidlago,
peternied,
reta,
stephen-crawford and
willyborankin
as code owners
4 tasks
stephen-crawford
approved these changes
Dec 19, 2023
Contributor
stephen-crawford
left a comment
stephen-crawford
left a comment
There was a problem hiding this comment.
I went ahead and compared this to main. This makes the files identical so assuming the CI passes this is appropriate. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Integration test PR. I followed directions from #3602 (comment) not sure if it should look like that though.
Issues Resolved
This is backport
#3426
#3602
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.