Deprecate opendistro API paths#5102
Merged
Merged
Conversation
Signed-off-by: shikharj05 <8859327+shikharj05@users.noreply.github.com>
Signed-off-by: shikharj05 <8859327+shikharj05@users.noreply.github.com>
Signed-off-by: shikharj05 <8859327+shikharj05@users.noreply.github.com>
Signed-off-by: shikharj05 <8859327+shikharj05@users.noreply.github.com>
Signed-off-by: shikharj05 <8859327+shikharj05@users.noreply.github.com>
Signed-off-by: shikharj05 <8859327+shikharj05@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5102 +/- ##
==========================================
+ Coverage 71.60% 71.65% +0.05%
==========================================
Files 335 335
Lines 22665 22731 +66
Branches 3598 3598
==========================================
+ Hits 16229 16288 +59
- Misses 4634 4641 +7
Partials 1802 1802
|
Member
|
@shikharj05 The changes look good to me in this PR. What is remaining before taking it out of draft? |
Collaborator
Author
I was blocked on #5053 for testing, will re-base, test couple of APIs and remove this out of draft. |
Collaborator
Author
Moved to review state |
cwperks
approved these changes
Feb 17, 2025
RyanL1997
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation) Maintenance
Why these changes are required?
The security repo has lingering usages of the legacy terms like _opendistro is API paths, these are replaced with _plugins prefix, however legacy paths are not explicitly marked as deprecated.
What is the old behavior before changes and new behavior after changes?
If an API uses _opendistro as path, log a deprecation message.
e.g.
logs-
Issues Resolved
#5097
Is this a backport? If so, please add backport PR # and/or commits #, and remove
backport-failedlabel from the original PR.Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
Testing
TODO
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.