Skip to content

Adapt to core changes in SecureTransportParameters#5122

Merged
cwperks merged 1 commit intoopensearch-project:mainfrom
cwperks:upgrade-spring-security
Feb 24, 2025
Merged

Adapt to core changes in SecureTransportParameters#5122
cwperks merged 1 commit intoopensearch-project:mainfrom
cwperks:upgrade-spring-security

Conversation

@cwperks
Copy link
Copy Markdown
Member

@cwperks cwperks commented Feb 21, 2025

Description

Adapts to changes introduced in opensearch-project/OpenSearch#16962

Testing

Not sure how to test this adequately.

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Copy link
Copy Markdown
Member Author

cwperks commented Feb 21, 2025

@finnegancarroll @rishabhmaurya @reta this fixes the compilation issues, but I'm not sure if it addresses what you need.

How can we add testing for this?

@rishabhmaurya
Copy link
Copy Markdown
Contributor

rishabhmaurya commented Feb 21, 2025

I think it will addresses the issue #5011
thanks @cwperks

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 71.67%. Comparing base (5c3f921) to head (0d96bfe).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
.../security/ssl/OpenSearchSecureSettingsFactory.java 0.00% 10 Missing ⚠️
.../org/opensearch/security/ssl/SslConfiguration.java 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5122      +/-   ##
==========================================
+ Coverage   71.63%   71.67%   +0.04%     
==========================================
  Files         335      335              
  Lines       22732    22747      +15     
  Branches     3598     3598              
==========================================
+ Hits        16284    16304      +20     
+ Misses       4649     4647       -2     
+ Partials     1799     1796       -3     
Files with missing lines Coverage Δ
.../org/opensearch/security/ssl/SslConfiguration.java 78.84% <0.00%> (-3.16%) ⬇️
.../security/ssl/OpenSearchSecureSettingsFactory.java 61.90% <0.00%> (-19.35%) ⬇️

... and 8 files with indirect coverage changes

@reta
Copy link
Copy Markdown
Collaborator

reta commented Feb 21, 2025

@finnegancarroll @rishabhmaurya @reta this fixes the compilation issues, but I'm not sure if it addresses what you need.

Thanks @cwperks , I think @rishabhmaurya has already confirmed it is what he needs :)

@rishabhmaurya
Copy link
Copy Markdown
Contributor

rishabhmaurya commented Feb 21, 2025

How can we add testing for this?

@cwperks I think consumers of this interface should add tests for it. In security plugin, one test I can think of could be building SslContext successfully using these params. Something like - https://github.com/opensearch-project/OpenSearch/blob/main/plugins/arrow-flight-rpc/src/main/java/org/opensearch/arrow/flight/bootstrap/tls/DefaultSslContextProvider.java#L46

@cwperks
Copy link
Copy Markdown
Member Author

cwperks commented Feb 22, 2025

Taking this out of Draft in case it needs to be merged to unblock the build. This PR needs test cases added to verify this change.

@cwperks
Copy link
Copy Markdown
Member Author

cwperks commented Feb 24, 2025

Merging to unblock the build. I will follow this up w/ adding tests.

@cwperks cwperks merged commit 2cca355 into opensearch-project:main Feb 24, 2025
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants