Fix compilation issue after Secure gRPC PR (#17796) merged into core#5263
Merged
cwperks merged 11 commits intoopensearch-project:mainfrom Apr 10, 2025
Merged
Fix compilation issue after Secure gRPC PR (#17796) merged into core#5263cwperks merged 11 commits intoopensearch-project:mainfrom
cwperks merged 11 commits intoopensearch-project:mainfrom
Conversation
…ger() Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
reta
reviewed
Apr 10, 2025
reta
previously approved these changes
Apr 10, 2025
Member
Author
|
Need to pull in changes from #5262 as well to resolve CI failures. Windows bwc issues may be resolved by opensearch-project/OpenSearch#17878 |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
willyborankin
approved these changes
Apr 10, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5263 +/- ##
==========================================
- Coverage 72.09% 72.07% -0.03%
==========================================
Files 335 336 +1
Lines 22608 22614 +6
Branches 3554 3554
==========================================
- Hits 16299 16298 -1
- Misses 4542 4546 +4
- Partials 1767 1770 +3
🚀 New features to boost your workflow:
|
Member
Author
|
Waiting for updated windows artifacts (https://artifacts.opensearch.org/snapshots/core/opensearch/3.0.0-beta1-SNAPSHOT/opensearch-min-3.0.0-beta1-SNAPSHOT-windows-x64-latest.zip) that include opensearch-project/OpenSearch#17878 |
DarshitChanpura
approved these changes
Apr 10, 2025
5 tasks
66 tasks
shikharj05
approved these changes
Apr 10, 2025
Collaborator
DarshitChanpura
approved these changes
Apr 10, 2025
This was referenced Apr 10, 2025
DarshitChanpura
added a commit
to DarshitChanpura/security
that referenced
this pull request
Apr 21, 2025
…pensearch-project#5263) Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: Craig Perkins <cwperx@amazon.com> Co-authored-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a compilation issue after merge of opensearch-project/OpenSearch#17796 which altered the SecureSettingsFactory interface in core.
This PR is not a replacement for #5152. This is a PR in the interim to fix compilation issues, but the actual implementation will be provided in #5152
This PR also contains changes from #5262
Maintenance
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.