fix: Update System.env syntax for Gradle 9 compatibility#5577
Merged
Conversation
Signed-off-by: Daniel Widdis <widdis@gmail.com>
reta
approved these changes
Aug 21, 2025
RyanL1997
approved these changes
Aug 21, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5577 +/- ##
==========================================
+ Coverage 73.02% 73.05% +0.03%
==========================================
Files 408 408
Lines 25259 25259
Branches 3842 3842
==========================================
+ Hits 18445 18454 +9
+ Misses 4945 4937 -8
+ Partials 1869 1868 -1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Gradle build files to fix compatibility with Gradle 9.
Problem
The current syntax using
$System.env.VARIABLE_NAMEfor accessing environment variables is not compatible with Gradle 9.This format is used in this repository for Sonatype credentials for SNAPSHOT publication. This fails with under Gradle 9.
See example failed workflow here.
Solution
Update to use the
System.getenv()method instead:Example fix which restored successful snapshots: opensearch-project/opensearch-remote-metadata-sdk#245