Enhance Point In Time support with APIs to list active point-in-time searches#218
Merged
reta merged 1 commit intoopensearch-project:mainfrom Jun 21, 2024
Merged
Enhance Point In Time support with APIs to list active point-in-time searches#218reta merged 1 commit intoopensearch-project:mainfrom
reta merged 1 commit intoopensearch-project:mainfrom
Conversation
reta
force-pushed
the
list.pits
branch
2 times, most recently
from
79455ad to
61b6cd3
Compare
dblock
reviewed
Jan 17, 2024
| @@ -5,7 +5,7 @@ | |||
| * you may not use this file except in compliance with the License. | |||
Member
There was a problem hiding this comment.
What's the reason why this file is still called Elasticsearch...?
Collaborator
Author
There was a problem hiding this comment.
We copied this code :-) (from Spring Data Elasticsearch)
Member
There was a problem hiding this comment.
IANAL, but it's APLv2, so you can fork/rename it as you wish, you just cannot remote the license from the file
Collaborator
Author
There was a problem hiding this comment.
I mean we this is way more than just one class, and we have an issue #24 to think about addressing that at large (from you :-))
dlvenable
approved these changes
Jun 21, 2024
| ); | ||
|
|
||
| final long started = System.nanoTime(); | ||
| while ((System.nanoTime() - started) < TimeUnit.SECONDS.toNanos(120)) { |
Member
There was a problem hiding this comment.
It might be nice to bring in the Awaitility project and use that here.
This code would look something like:
await().atMost(Duration.ofSeconds(120))
.until(() -> operations.listPointInTime().isEmpty());
Collaborator
Author
There was a problem hiding this comment.
Yeah, I was thinking if bringing the whole new dependency is really justified at this moment (for one single test), seems like too much.
reta
force-pushed
the
list.pits
branch
2 times, most recently
from
2b6ce95 to
faaed4b
Compare
3 tasks
reta
commented
Jun 21, 2024
| @Override | ||
| public List<PitInfo> listPointInTime() { | ||
| return execute(client -> client.getAllPits(RequestOptions.DEFAULT)) | ||
| .getPitInfos().stream().map(pit -> new PitInfo(pit.getPitId(), pit.getCreationTime(), null)) |
Collaborator
Author
There was a problem hiding this comment.
reta
force-pushed
the
list.pits
branch
2 times, most recently
from
f9dba57 to
0e2de94
Compare
…searches Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta
added a commit
to reta/spring-data-opensearch
that referenced
this pull request
Jun 21, 2024
…searches (opensearch-project#218) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta
added a commit
to reta/spring-data-opensearch
that referenced
this pull request
Jun 21, 2024
…searches (opensearch-project#218) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta
added a commit
to reta/spring-data-opensearch
that referenced
this pull request
Jun 21, 2024
…searches (opensearch-project#218) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta
added a commit
to reta/spring-data-opensearch
that referenced
this pull request
Jun 22, 2024
…searches (opensearch-project#218) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta
added a commit
to reta/spring-data-opensearch
that referenced
this pull request
Jun 22, 2024
…searches (opensearch-project#218) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta
added a commit
to reta/spring-data-opensearch
that referenced
this pull request
Jun 22, 2024
…searches (opensearch-project#218) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
This was referenced Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enhance Point In Time support with APIs to list active point-in-time searches
Issues Resolved
Part of #85
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.