Remove jackson databind and jackson annotations dependency now coming from core #2325#37
Closed
YANG-DB wants to merge 5 commits intoopensearch-project:mainfrom
YANG-DB:Remove_jackson-databind_and_jackson-annotations_dependency_now_coming_from_core_#2325
Closed
Remove jackson databind and jackson annotations dependency now coming from core #2325#37YANG-DB wants to merge 5 commits intoopensearch-project:mainfrom YANG-DB:Remove_jackson-databind_and_jackson-annotations_dependency_now_coming_from_core_#2325
YANG-DB wants to merge 5 commits intoopensearch-project:mainfrom
YANG-DB:Remove_jackson-databind_and_jackson-annotations_dependency_now_coming_from_core_#2325
Conversation
…s in server of opensearch core. The security plugin now gets these dependencies transitively and does not need direct dependencies on the jars. PR in core where the dependencies are added: opensearch-project/OpenSearch#5366 Signed-off-by: YANGDB <yang.db.dev@gmail.com>
…s in server of opensearch core. The security plugin now gets these dependencies transitively and does not need direct dependencies on the jars. PR in core where the dependencies are added: opensearch-project/OpenSearch#5366 Signed-off-by: YANGDB <yang.db.dev@gmail.com>
…son-annotations_dependency_now_coming_from_core_#2325' into Remove_jackson-databind_and_jackson-annotations_dependency_now_coming_from_core_#2325
…son-annotations_dependency_now_coming_from_core_#2325' into Remove_jackson-databind_and_jackson-annotations_dependency_now_coming_from_core_#2325 Signed-off-by: YANGDB <yang.db.dev@gmail.com>
…son-annotations_dependency_now_coming_from_core_#2325' into Remove_jackson-databind_and_jackson-annotations_dependency_now_coming_from_core_#2325
penghuo
approved these changes
Dec 14, 2022
Collaborator
penghuo
left a comment
penghuo
left a comment
There was a problem hiding this comment.
I think JDBC does not depend on OpenSearch? How does JDBC depend on jackson transitively? or Does it means JDBC does not depend on jackson?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
jackson-databind and jackson-annotations were added as api dependencies in server of opensearch core. The security plugin now gets these dependencies transitively and does not need direct dependencies on the jars.
PR in core where the dependencies are added: opensearch-project/OpenSearch#5366
In addition
Category
(Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation) Maintenance
Issues Resolved
opensearch-project/OpenSearch#5366
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.