Skip to content

fix: Update System.env syntax for Gradle 9 compatibility#4090

Merged
penghuo merged 1 commit into
opensearch-project:mainfrom
dbwiddis:fix-gradle-9-syntax
Aug 28, 2025
Merged

fix: Update System.env syntax for Gradle 9 compatibility#4090
penghuo merged 1 commit into
opensearch-project:mainfrom
dbwiddis:fix-gradle-9-syntax

Conversation

@dbwiddis
Copy link
Copy Markdown
Member

This PR updates the Gradle build files to fix compatibility with Gradle 9.

Problem

The current syntax using $System.env.VARIABLE_NAME for accessing environment variables is not compatible with Gradle 9.

This format is used in this repository for Sonatype credentials for SNAPSHOT publication. This fails with under Gradle 9.

credentials {
    username = "$System.env.SONATYPE_USERNAME"
    password = "$System.env.SONATYPE_PASSWORD"
}

See example failed workflow here.

Solution

Update to use the System.getenv() method instead:

credentials {
    username = System.getenv("SONATYPE_USERNAME")
    password = System.getenv("SONATYPE_PASSWORD")
}

Example fix which restored successful snapshots: opensearch-project/opensearch-remote-metadata-sdk#245

Signed-off-by: Daniel Widdis <widdis@gmail.com>
@penghuo penghuo merged commit e1be2a5 into opensearch-project:main Aug 28, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Improves code quality, but not the product

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants