MGMT-23517: Bump go modules

[pastequo]

Newest version of gwh removed an exported symbol that we were using, this PR contains the associated migration

Unfortunately gwh is not exporting the Modifier struct (inside internal/) so it's really not convenient for our signature. They also support multiple ways to provide options, so they ended up putting "any" in their signature, and we have to follow :/

[openshift-ci-robot]

@pastequo: This pull request references MGMT-23517 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0e47b03d-c352-438b-a5b1-f5db252e6516

📥 Commits

Reviewing files that changed from the base of the PR and between 830f2ab and f517d79.

⛔ Files ignored due to path filters (112)

• go.sum is excluded by !**/*.sum
• vendor/github.com/StackExchange/wmi/LICENSE is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/StackExchange/wmi/README.md is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/StackExchange/wmi/swbemservices.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/StackExchange/wmi/wmi.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/.gitignore is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/Makefile is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/README.md is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/SNAPSHOT.md is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/alias.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/host.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/internal/config/context.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/internal/config/log.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/internal/log/log.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/accelerator/accelerator.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/accelerator/accelerator_linux.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/accelerator/accelerator_stub.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/accelerator/accelerator_windows.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/baseboard/baseboard.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/baseboard/baseboard_linux.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/baseboard/baseboard_stub.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/baseboard/baseboard_windows.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/bios/bios.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/bios/bios_linux.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/bios/bios_stub.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/bios/bios_windows.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/block/block.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/block/block_darwin.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/block/block_linux.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/block/block_stub.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/block/block_windows.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/chassis/chassis.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/chassis/chassis_linux.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/chassis/chassis_stub.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/chassis/chassis_windows.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/context/context.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/cpu/cpu.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/cpu/cpu_darwin.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/cpu/cpu_linux.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/cpu/cpu_stub.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/cpu/cpu_windows.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/gpu/gpu.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/gpu/gpu_linux.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/gpu/gpu_stub.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/gpu/gpu_windows.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/linuxdmi/dmi_linux.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/linuxpath/path_linux.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/marshal/marshal.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/memory/memory.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/memory/memory_cache_linux.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/memory/memory_linux.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/memory/memory_stub.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/memory/memory_windows.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/net/net.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/net/net_linux.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/net/net_stub.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/net/net_windows.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/option/option.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/pci/pci.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/pci/pci_linux.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/pci/pci_stub.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/product/product.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/product/product_linux.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/product/product_stub.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/product/product_windows.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/snapshot/clonetree.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/snapshot/clonetree_block_linux.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/snapshot/clonetree_gpu_linux.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/snapshot/clonetree_linux.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/snapshot/clonetree_net_linux.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/snapshot/clonetree_pci_linux.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/snapshot/clonetree_stub.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/snapshot/pack.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/snapshot/testdata.tar.gz is excluded by !**/*.gz, !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/snapshot/trace.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/snapshot/unpack.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/topology/topology.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/topology/topology_linux.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/topology/topology_stub.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/topology/topology_windows.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/usb/usb.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/usb/usb_linux.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/usb/usb_stub.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/ghw/pkg/util/util.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/pcidb/README.md is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/pcidb/context.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/pcidb/discover.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/pcidb/internal/discover.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/pcidb/internal/option.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/pcidb/internal/parse.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/pcidb/main.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/pcidb/pcidb.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/pcidb/types/class.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/pcidb/types/db.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/pcidb/types/default.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/pcidb/types/env.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/pcidb/types/error.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/pcidb/types/option.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/pcidb/types/product.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/pcidb/types/programming_interface.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/pcidb/types/subclass.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/jaypipes/pcidb/types/vendor.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/mitchellh/go-homedir/LICENSE is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/mitchellh/go-homedir/README.md is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/mitchellh/go-homedir/homedir.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/yusufpapurcu/wmi/wmi.go is excluded by !vendor/**, !**/vendor/**
• vendor/howett.net/plist/bplist_parser.go is excluded by !vendor/**, !**/vendor/**
• vendor/howett.net/plist/marshal.go is excluded by !vendor/**, !**/vendor/**
• vendor/howett.net/plist/text_parser.go is excluded by !vendor/**, !**/vendor/**
• vendor/howett.net/plist/typeinfo.go is excluded by !vendor/**, !**/vendor/**
• vendor/howett.net/plist/unmarshal.go is excluded by !vendor/**, !**/vendor/**
• vendor/modules.txt is excluded by !vendor/**, !**/vendor/**

📒 Files selected for processing (7)

• go.mod
• src/inventory/disks_test.go
• src/inventory/system_vendor_test.go
• src/scanners/machine_uuid_scanner.go
• src/scanners/mock_SerialDiscovery.go
• src/util/dependencies.go
• src/util/mock_IDependencies.go

✅ Files skipped from review due to trivial changes (1)

• go.mod

---

Walkthrough

Updated Go module versions in go.mod and changed several ghw-related APIs from *ghw.WithOption-typed variadic parameters to generic variadic any/interface{} across dependencies, mocks, scanners, and tests to accommodate upstream library signature changes.

Changes

Cohort / File(s)	Summary
Module file go.mod	Bumped github.com/jaypipes/ghw v0.16.0 → v0.23.0, github.com/jaypipes/pcidb v1.0.1 → v1.1.1; updated indirects (github.com/yusufpapurcu/wmi, howett.net/plist) and removed indirect entries for github.com/StackExchange/wmi and github.com/mitchellh/go-homedir.
Core dependencies API src/util/dependencies.go	Changed IDependencies methods and Dependencies implementations to accept opts ...any instead of opts ...*ghw.WithOption; forwarded variadic args to ghw calls.
Mocks for dependencies src/util/mock_IDependencies.go, src/scanners/mock_SerialDiscovery.go	Removed option import; updated mock method signatures to ...interface{} and simplified variadic argument handling and dynamic return-function assertions to func(...interface{}) ....
Scanners (serial discovery) src/scanners/machine_uuid_scanner.go	Updated SerialDiscovery interface and GHWSerialDiscovery methods Product and Baseboard to accept opts ...any and forward them to ghw.
Tests adjusting matchers src/inventory/disks_test.go, src/inventory/system_vendor_test.go	Relaxed mocked ghw option matchers to use mock.AnythingOfType("config.Modifier"); added testify/mock import where needed.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pastequo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [pastequo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.52%. Comparing base (dd12f4a) to head (f517d79).
⚠️ Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
src/util/dependencies.go	0.00%	6 Missing ⚠️
src/scanners/machine_uuid_scanner.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1373   +/-   ##
=======================================
  Coverage   56.52%   56.52%           
=======================================
  Files          88       88           
  Lines        4315     4315           
=======================================
  Hits         2439     2439           
  Misses       1699     1699           
  Partials      177      177           

Files with missing lines	Coverage Δ
src/scanners/machine_uuid_scanner.go	67.74% <0.00%> (ø)
src/util/dependencies.go	0.00% <0.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gamli75]

/retest

[openshift-ci-robot]

@pastequo: This pull request references MGMT-23517 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Unfortunately gwh is not exporter the Modifier struct (inside internal/) so it's really not convenient for our signature. They also support multiple ways to provide options, so they ended up putting "any" in their signature, and we have to follow :/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@pastequo: This pull request references MGMT-23517 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Unfortunately gwh is not exporting the Modifier struct (inside internal/) so it's really not convenient for our signature. They also support multiple ways to provide options, so they ended up putting "any" in their signature, and we have to follow :/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@pastequo: This pull request references MGMT-23517 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Newest version of gwh removed an exported symbol that we were using, this PR contains the associated migration

Unfortunately gwh is not exporting the Modifier struct (inside internal/) so it's really not convenient for our signature. They also support multiple ways to provide options, so they ended up putting "any" in their signature, and we have to follow :/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pastequo]

/override ci/prow/edge-e2e-ai-operator-ztp

[openshift-ci]

@pastequo: Overrode contexts on behalf of pastequo: ci/prow/edge-e2e-ai-operator-ztp

Details

In response to this:

/override ci/prow/edge-e2e-ai-operator-ztp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@pastequo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[pastequo]

jaypipes/ghw#456

[jaypipes]

link jaypipes/ghw#457. /cc @ffromani

[omer-vishlitzky]

/lgtm
/approved