NO-ISSUE: [master] Bump OCP versions: 4.18, 4.21, 4.14, 4.20#10094
NO-ISSUE: [master] Bump OCP versions: 4.18, 4.21, 4.14, 4.20#10094danmanor wants to merge 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@danmanor: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@danmanor: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
WalkthroughThis pull request updates OpenShift release image references across three configuration files by bumping patch versions for releases 4.14, 4.18, 4.20, and 4.21 across multiple CPU architectures (x86_64, aarch64, and multi). Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
bot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danmanor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
deploy/podman/configmap.yml (1)
30-30: Reduce multi-file drift risk forRELEASE_IMAGES.This large inline JSON is hand-maintained in multiple files, which is error-prone for future bumps. Consider generating this value from a single source (for example
data/default_release_images.json) during release update automation.As per coding guidelines, "-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@deploy/podman/configmap.yml` at line 30, The RELEASE_IMAGES entry in configmap.yml is a large hand-maintained JSON blob causing drift; move the canonical data into a single source file (e.g., data/default_release_images.json) and update the release automation and config rendering so RELEASE_IMAGES is generated from that file (or injected via a configMapGenerator/kustomize step or CI templating) instead of being inlined; update the configmap.yml rendering logic to pull the JSON from that source during release bumps and adjust any scripts that currently edit the RELEASE_IMAGES key to read/write the single source file.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@deploy/podman/configmap.yml`:
- Line 30: The RELEASE_IMAGES entry in configmap.yml is a large hand-maintained
JSON blob causing drift; move the canonical data into a single source file
(e.g., data/default_release_images.json) and update the release automation and
config rendering so RELEASE_IMAGES is generated from that file (or injected via
a configMapGenerator/kustomize step or CI templating) instead of being inlined;
update the configmap.yml rendering logic to pull the JSON from that source
during release bumps and adjust any scripts that currently edit the
RELEASE_IMAGES key to read/write the single source file.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3643c488-e99f-476f-aa49-b7cb49c79321
📒 Files selected for processing (3)
data/default_release_images.jsondeploy/podman/configmap.ymlopenshift/template.yaml
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10094 +/- ##
=======================================
Coverage 44.27% 44.28%
=======================================
Files 416 416
Lines 72549 72549
=======================================
+ Hits 32123 32126 +3
+ Misses 37521 37519 -2
+ Partials 2905 2904 -1 🚀 New features to boost your workflow:
|
|
@danmanor: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
OpenShift updates: 4.18.35-multi -> 4.18.36-multi, 4.14.62 -> 4.14.63, 4.20.16-multi -> 4.20.17-multi, 4.21.7 -> 4.21.8, 4.18.35 -> 4.18.36, 4.20.16 -> 4.20.17, 4.21.7-multi -> 4.21.8-multi, 4.14.62-multi -> 4.14.63-multi
RHCOS updates:
/test edge-e2e-metal-assisted-4-18 edge-e2e-metal-assisted-4-21 edge-e2e-metal-assisted-4-14 edge-e2e-metal-assisted-4-20
/cc @rccrdpccl @gamli75