primary_stack hardcoded names to const - before change to int

[bkopilov]

Move primary stack name to const and uses for stack type. In case primary type will be changed to int , we will have to change in single location.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bkopilov
Once this PR has been reviewed and has the lgtm label, please assign adriengentil for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @bkopilov. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[bkopilov]

@linoyaslan , @danmanor

[linoyaslan]

/lgtm

[linoyaslan]

/hold

[openshift-ci]

@bkopilov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-assisted-4-20	3d95b58	link	true	/test e2e-metal-assisted-4-20
ci/prow/e2e-metal-assisted-ha-kube-api-ipv4-4-20	3d95b58	link	true	/test e2e-metal-assisted-ha-kube-api-ipv4-4-20

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[bkopilov]

Hi , @linoyaslan
I have tested it locally with assisted (latest code )
I create a single place to change the primary ipv6 , ipv4 location when the db name will be changed

[bkopilov]

/retest

[openshift-ci]

@bkopilov: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.