Skip to content

Update oc config access for single node#2798

Open
bkopilov wants to merge 1 commit intoopenshift:masterfrom
bkopilov:sno_post_install_access
Open

Update oc config access for single node#2798
bkopilov wants to merge 1 commit intoopenshift:masterfrom
bkopilov:sno_post_install_access

Conversation

@bkopilov
Copy link
Copy Markdown
Contributor

On SNO , get_ip_for_single_node verifies machine_cidr for ipv4 Change the machine_cidr and pass ipv4 even when dual-stack primary ipv6

@openshift-ci openshift-ci bot requested review from eranco74 and yoavsc0302 March 22, 2026 18:11
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 22, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bkopilov
Once this PR has been reviewed and has the lgtm label, please assign adriengentil for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 22, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 22, 2026

Hi @bkopilov. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 22, 2026
@danmanor
Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 23, 2026
@bkopilov bkopilov force-pushed the sno_post_install_access branch 2 times, most recently from bd4474f to f27328e Compare March 23, 2026 14:34
@bkopilov
Copy link
Copy Markdown
Contributor Author

/retest

2 similar comments
@bkopilov
Copy link
Copy Markdown
Contributor Author

/retest

@danmanor
Copy link
Copy Markdown
Contributor

/retest

@danmanor
Copy link
Copy Markdown
Contributor

@bkopilov ci/prow/e2e-metal-assisted-ha-kube-api-ipv4-4-22 is broken, but looks like the PR hits ci/prow/e2e-metal-sno-live-iso

@bkopilov
Copy link
Copy Markdown
Contributor Author

bkopilov commented Mar 25, 2026 via email

On SNO , get_ip_for_single_node verifies machine_cidr for ipv4
Change the machine_cidr and pass ipv4 even when dual-stack primary ipv6
@bkopilov bkopilov force-pushed the sno_post_install_access branch from f27328e to 3bfee65 Compare March 25, 2026 13:23
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 25, 2026

@bkopilov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-sno-live-iso 3bfee65 link true /test e2e-metal-sno-live-iso
ci/prow/e2e-metal-assisted-ha-kube-api-ipv4-4-22 3bfee65 link true /test e2e-metal-assisted-ha-kube-api-ipv4-4-22

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants