Skip to content

OCPBUGS-81340: pacemaker CronJob: tune history limit and Job TTL#1581

Open
jaypoulz wants to merge 1 commit intoopenshift:mainfrom
jaypoulz:ocpbugs-81340-pacemaker-cronjob-ttl
Open

OCPBUGS-81340: pacemaker CronJob: tune history limit and Job TTL#1581
jaypoulz wants to merge 1 commit intoopenshift:mainfrom
jaypoulz:ocpbugs-81340-pacemaker-cronjob-ttl

Conversation

@jaypoulz
Copy link
Copy Markdown
Contributor

Raise successfulJobsHistoryLimit to 12 and set ttlSecondsAfterFinished to 300s so finished Jobs are typically removed by the TTL-after-finished controller before the CronJob controller prunes for history, reducing SuccessfulDelete event spam on the CronJob (openshift-etcd).

This only helps alleviate the delete event spam, not the create event spam.

Made-with: Cursor

Raise successfulJobsHistoryLimit to 12 and set ttlSecondsAfterFinished to 300s
so finished Jobs are typically removed by the TTL-after-finished controller
before the CronJob controller prunes for history, reducing SuccessfulDelete
event spam on the CronJob (openshift-etcd).

Made-with: Cursor
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 30, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@jaypoulz: This pull request references Jira Issue OCPBUGS-81340, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Raise successfulJobsHistoryLimit to 12 and set ttlSecondsAfterFinished to 300s so finished Jobs are typically removed by the TTL-after-finished controller before the CronJob controller prunes for history, reducing SuccessfulDelete event spam on the CronJob (openshift-etcd).

This only helps alleviate the delete event spam, not the create event spam.

Made-with: Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e7f2ca19-c752-41bc-bc88-d9117bb0113d

📥 Commits

Reviewing files that changed from the base of the PR and between 94594c8 and b37aef7.

📒 Files selected for processing (1)
  • bindata/tnfdeployment/cronjob.yaml

Walkthrough

A CronJob configuration update that increases the successful job history limit from 1 to 12 and decreases the job TTL from 600 to 300 seconds, with an added explanatory comment clarifying the relationship between these retention parameters.

Changes

Cohort / File(s) Summary
CronJob Configuration
bindata/tnfdeployment/cronjob.yaml
Updated spec.successfulJobsHistoryLimit from 1 to 12, reduced spec.jobTemplate.spec.ttlSecondsAfterFinished from 600 to 300, and added inline comment documenting the interaction between TTL deletion and CronJob pruning mechanisms.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from clobrano and eggfoobar March 30, 2026 18:50
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaypoulz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2026
@eggfoobar
Copy link
Copy Markdown
Contributor

/test e2e-aws-etcd-certrotation

@eggfoobar
Copy link
Copy Markdown
Contributor

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-techpreview

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 30, 2026

@eggfoobar: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0d243f20-2c6e-11f1-9a34-23c49e266fdc-0

@eggfoobar
Copy link
Copy Markdown
Contributor

/test e2e-aws-etcd-certrotation

@eggfoobar
Copy link
Copy Markdown
Contributor

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-techpreview

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 31, 2026

@eggfoobar: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0ae31830-2caf-11f1-833c-3ccecba63957-0

@jaypoulz
Copy link
Copy Markdown
Contributor Author

jaypoulz commented Apr 1, 2026

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 1, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@jaypoulz: This pull request references Jira Issue OCPBUGS-81340, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jaypoulz
Copy link
Copy Markdown
Contributor Author

jaypoulz commented Apr 1, 2026

/retest-required

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 1, 2026

@jaypoulz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-etcd-certrotation b37aef7 link false /test e2e-aws-etcd-certrotation
ci/prow/unit b37aef7 link true /test unit
ci/prow/e2e-aws-ovn-single-node b37aef7 link true /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants