OCPBUGS-81340: pacemaker CronJob: tune history limit and Job TTL#1581
OCPBUGS-81340: pacemaker CronJob: tune history limit and Job TTL#1581jaypoulz wants to merge 1 commit intoopenshift:mainfrom
Conversation
Raise successfulJobsHistoryLimit to 12 and set ttlSecondsAfterFinished to 300s so finished Jobs are typically removed by the TTL-after-finished controller before the CronJob controller prunes for history, reducing SuccessfulDelete event spam on the CronJob (openshift-etcd). Made-with: Cursor
|
@jaypoulz: This pull request references Jira Issue OCPBUGS-81340, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA CronJob configuration update that increases the successful job history limit from 1 to 12 and decreases the job TTL from 600 to 300 seconds, with an added explanatory comment clarifying the relationship between these retention parameters. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaypoulz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws-etcd-certrotation |
|
/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-techpreview |
|
@eggfoobar: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0d243f20-2c6e-11f1-9a34-23c49e266fdc-0 |
|
/test e2e-aws-etcd-certrotation |
|
/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-techpreview |
|
@eggfoobar: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0ae31830-2caf-11f1-833c-3ccecba63957-0 |
|
/jira refresh |
|
@jaypoulz: This pull request references Jira Issue OCPBUGS-81340, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
@jaypoulz: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Raise successfulJobsHistoryLimit to 12 and set ttlSecondsAfterFinished to 300s so finished Jobs are typically removed by the TTL-after-finished controller before the CronJob controller prunes for history, reducing SuccessfulDelete event spam on the CronJob (openshift-etcd).
This only helps alleviate the delete event spam, not the create event spam.
Made-with: Cursor