Skip to content

upkeep: update featureset to match DualReplica promotion#1587

Open
eggfoobar wants to merge 1 commit intoopenshift:mainfrom
eggfoobar:upkeep-pacemaker-crd-featuregate
Open

upkeep: update featureset to match DualReplica promotion#1587
eggfoobar wants to merge 1 commit intoopenshift:mainfrom
eggfoobar:upkeep-pacemaker-crd-featuregate

Conversation

@eggfoobar
Copy link
Copy Markdown
Contributor

Update pacemaker annotation to reflect DualReplica featureGate promotion to GA.

Pacemaker depends on DualReplica as a featureGate, when DualReplica is promoted to Default, this featureSet annotation will no longer be relevant and will cause issues in our static resource controller that tries to apply this CRD causing needless update events. We will need to remove this annotation when the promotion is done.

Signed-off-by: ehila <ehila@redhat.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e13e7df4-23a3-4fc9-a2a2-068e3bf37c1f

📥 Commits

Reviewing files that changed from the base of the PR and between e05708b and bb1fda3.

📒 Files selected for processing (1)
  • bindata/etcd/pacemakercluster-crd.yaml
💤 Files with no reviewable changes (1)
  • bindata/etcd/pacemakercluster-crd.yaml

Walkthrough

Removed the metadata.annotations["release.openshift.io/feature-set"] annotation from the PacemakerCluster CustomResourceDefinition in the etcd configuration. All other CRD schema, naming, versioning, and subresource declarations remain unchanged.

Changes

Cohort / File(s) Summary
CRD Annotation Removal
bindata/etcd/pacemakercluster-crd.yaml
Removed a single metadata annotation (release.openshift.io/feature-set) from the PacemakerCluster CustomResourceDefinition.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from dusk125 and tjungblu April 1, 2026 03:59
@eggfoobar
Copy link
Copy Markdown
Contributor Author

/hold for openshift/api#2490

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 1, 2026

@eggfoobar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tjungblu
Copy link
Copy Markdown
Contributor

tjungblu commented Apr 1, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 1, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants