upkeep: update featureset to match DualReplica promotion#1587
upkeep: update featureset to match DualReplica promotion#1587eggfoobar wants to merge 1 commit intoopenshift:mainfrom
Conversation
Signed-off-by: ehila <ehila@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughRemoved the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/hold for openshift/api#2490 |
|
@eggfoobar: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eggfoobar, tjungblu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update pacemaker annotation to reflect DualReplica featureGate promotion to GA.
Pacemaker depends on DualReplica as a featureGate, when DualReplica is promoted to Default, this featureSet annotation will no longer be relevant and will cause issues in our static resource controller that tries to apply this CRD causing needless update events. We will need to remove this annotation when the promotion is done.