OCPBUGS-78541: Move TestIngressControllerCustomEndpoints to run last#1388
OCPBUGS-78541: Move TestIngressControllerCustomEndpoints to run last#1388alebedev87 wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
Skipping CI for Draft Pull Request. |
|
@alebedev87: This pull request references Jira Issue OCPBUGS-78541, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe change reorganizes test execution in the e2e test suite by relocating TestIngressControllerCustomEndpoints from parallel test execution to serial test execution. Explanatory comments are added noting that this test must run last because it modifies Infrastructure.spec.aws.serviceEndpoints, which triggers a cluster-wide rollout. No exported or public declarations were modified in the change. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
|
/jira refresh |
|
@alebedev87: This pull request references Jira Issue OCPBUGS-78541, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (iamin@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
a5290f4 to
e8afae7
Compare
|
@alebedev87: This pull request references Jira Issue OCPBUGS-78541, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (iamin@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Modifying `Infrastructure.spec.platformSpec.aws.serviceEndpoints` triggers `MachineConfig` re-rendering, causing a full cluster node rollout. Running this test last avoids disrupting other tests.
e8afae7 to
7e92761
Compare
|
e2e-aws-operator test passed second time in a row, trying again to get more data /test e2e-aws-operator |
|
/test e2e-hypershift |
|
/retest-required |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@alebedev87: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Modifying
Infrastructure.spec.platformSpec.aws.serviceEndpointstriggersMachineConfigre-rendering, causing a full cluster node rollout. Running this test last avoids disrupting other tests.