Skip to content

OCPBUGS-78541: Move TestIngressControllerCustomEndpoints to run last#1388

Open
alebedev87 wants to merge 1 commit intoopenshift:masterfrom
alebedev87:skip-custom-endpoints-hcp
Open

OCPBUGS-78541: Move TestIngressControllerCustomEndpoints to run last#1388
alebedev87 wants to merge 1 commit intoopenshift:masterfrom
alebedev87:skip-custom-endpoints-hcp

Conversation

@alebedev87
Copy link
Contributor

@alebedev87 alebedev87 commented Mar 16, 2026

Modifying Infrastructure.spec.platformSpec.aws.serviceEndpoints triggers MachineConfig re-rendering, causing a full cluster node rollout. Running this test last avoids disrupting other tests.

@openshift-ci-robot openshift-ci-robot added the jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. label Mar 16, 2026
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 16, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 16, 2026
@openshift-ci-robot
Copy link
Contributor

@alebedev87: This pull request references Jira Issue OCPBUGS-78541, which is invalid:

  • expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "4.20" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR aims at reducing the flakiness of e2e-aws-operator test related to failed LB provisioning. It's likely to be caused by side effects of TestIngressControllerCustomEndpoints.

  • Skip TestIngressControllerCustomEndpoints on external control plane topology

On HyperShift/ROSA clusters the Cloud Controller Manager runs on the
hosting cluster, so the guest cluster cannot track its rollout after an
Infrastructure config change. Running the test anyway risks LB provision
errors in subsequent tests caused by CCM leader re-election during a
machine config update.

  • Move TestIngressControllerCustomEndpoints to run last

Modifying Infrastructure.spec.platformSpec.aws.serviceEndpoints
triggers MachineConfig re-rendering, causing a full cluster node
rollout. Running this test last avoids disrupting other tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@alebedev87 alebedev87 marked this pull request as ready for review March 16, 2026 16:04
@coderabbitai
Copy link

coderabbitai bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 0eaf8bca-8a75-454f-b98e-902dfa5848a6

📥 Commits

Reviewing files that changed from the base of the PR and between a5290f4 and 7e92761.

📒 Files selected for processing (1)
  • test/e2e/all_test.go
🚧 Files skipped from review as they are similar to previous changes (1)
  • test/e2e/all_test.go

📝 Walkthrough

Walkthrough

The change reorganizes test execution in the e2e test suite by relocating TestIngressControllerCustomEndpoints from parallel test execution to serial test execution. Explanatory comments are added noting that this test must run last because it modifies Infrastructure.spec.aws.serviceEndpoints, which triggers a cluster-wide rollout. No exported or public declarations were modified in the change.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 16, 2026
@alebedev87
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 16, 2026
@openshift-ci-robot
Copy link
Contributor

@alebedev87: This pull request references Jira Issue OCPBUGS-78541, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (iamin@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@alebedev87 alebedev87 changed the title OCPBUGS-78541: Address issue caused by TestIngressControllerCustomEndpoints side effects OCPBUGS-78541: Address issues caused by TestIngressControllerCustomEndpoints side effects Mar 16, 2026
@alebedev87 alebedev87 force-pushed the skip-custom-endpoints-hcp branch from a5290f4 to e8afae7 Compare March 16, 2026 19:59
@openshift-ci-robot
Copy link
Contributor

@alebedev87: This pull request references Jira Issue OCPBUGS-78541, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (iamin@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Modifying Infrastructure.spec.platformSpec.aws.serviceEndpoints triggers MachineConfig re-rendering, causing a full cluster node rollout. Running this test last avoids disrupting other tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Modifying `Infrastructure.spec.platformSpec.aws.serviceEndpoints`
triggers `MachineConfig` re-rendering, causing a full cluster node
rollout. Running this test last avoids disrupting other tests.
@alebedev87 alebedev87 force-pushed the skip-custom-endpoints-hcp branch from e8afae7 to 7e92761 Compare March 16, 2026 20:00
@alebedev87 alebedev87 changed the title OCPBUGS-78541: Address issues caused by TestIngressControllerCustomEndpoints side effects OCPBUGS-78541: Move TestIngressControllerCustomEndpoints to run last Mar 16, 2026
@alebedev87
Copy link
Contributor Author

e2e-aws-operator test passed second time in a row, trying again to get more data

/test e2e-aws-operator

@alebedev87
Copy link
Contributor Author

/test e2e-hypershift

@rikatz
Copy link
Member

rikatz commented Mar 18, 2026

/retest-required

@rikatz
Copy link
Member

rikatz commented Mar 18, 2026

/lgtm
/approve
the failing tests are being caused by something else.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 19, 2026

@alebedev87: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-hypershift-conformance 7e92761 link true /test e2e-aws-ovn-hypershift-conformance

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants