OCPBUGS-80930: Add VolumeAttributesClass e2e test manifests for Azure disk#538
OCPBUGS-80930: Add VolumeAttributesClass e2e test manifests for Azure disk#538radeore wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughTwo new files were added under ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@test/e2e/azure-disk/ultrassd-manifest.yaml`:
- Line 28: Update the UltraSSD manifest so the storage class/property
onlineExpansion is set to true (change the current onlineExpansion: false to
onlineExpansion: true) to reflect Azure UltraSSD and CSI driver v1.34+ support
for online volume expansion; modify the ultrassd manifest entry that defines
onlineExpansion so e2e tests exercise online expansion scenarios correctly.
In `@test/e2e/azure-disk/volumeattributesclass.yaml`:
- Around line 6-8: Update the volumeattributesclass parameters to match the
Azure Disk CSI driver's documented casing by renaming DiskIOPSReadWrite ->
diskIOPSReadWrite and DiskMBpsReadWrite -> diskMBpsReadWrite in the YAML, and
verify that the numeric values (1000 IOPS, 200 MBps) are appropriate for the
intended disk SKU/size (since Azure enforces size-dependent IOPS/MBps limits)
before committing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 6906e604-82b1-4ebc-a3c2-cf02a6745948
📒 Files selected for processing (2)
test/e2e/azure-disk/ultrassd-manifest.yamltest/e2e/azure-disk/volumeattributesclass.yaml
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: radeore The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest-required |
|
/test hypershift-e2e-aks |
|
/test ? |
|
/test e2e-azure-csi-volumeattributesclass |
1 similar comment
|
/test e2e-azure-csi-volumeattributesclass |
|
'e2e-azure-csi-volumeattributesclass' is failing due to default storageClass issue, fixed this issue in openshift/release#77248 |
|
/test e2e-azure-csi-volumeattributesclass |
|
/retitle OCPBUGS-80930: Add VolumeAttributesClass e2e test manifests for Azure disk |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/severity-moderate
|
@radeore: This pull request references Jira Issue OCPBUGS-80930, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@Phaow: This pull request references Jira Issue OCPBUGS-80930, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
|
@radeore: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
The new failure caused by UltraSSD_LRS only support None caching mode, in vac test jobs we must add explicit cachingMode for UltraSSD StorageClass. I opened openshift/release#77362 fix it, let's see whether we still needs some extra configurations. ...
2026-04-03T02:30:16.010555510Z E0403 02:30:16.010526 1 utils.go:110] GRPC error: rpc error: code = Internal desc = Attach volume pvc-c815310f-5489-4680-abf4-a6bbb84ace72 to instance ci-op-pb7r2m8f-ccb8f-tbtr9-worker-eastus2-xgxk2 failed with PUT https://management.azure.com/subscriptions/d38f1e38-4bed-438e-b227-833f997adf6a/resourceGroups/ci-op-pb7r2m8f-ccb8f-tbtr9-rg/providers/Microsoft.Compute/virtualMachines/ci-op-pb7r2m8f-ccb8f-tbtr9-worker-eastus2-xgxk2
2026-04-03T02:30:16.010555510Z --------------------------------------------------------------------------------
2026-04-03T02:30:16.010555510Z RESPONSE 400: 400 Bad Request
2026-04-03T02:30:16.010555510Z ERROR CODE: InvalidParameter
2026-04-03T02:30:16.010555510Z --------------------------------------------------------------------------------
2026-04-03T02:30:16.010555510Z {
2026-04-03T02:30:16.010555510Z "error": {
2026-04-03T02:30:16.010555510Z "code": "InvalidParameter",
2026-04-03T02:30:16.010555510Z "message": "Storage Account type UltraSSD_LRS is not supported with caching type ReadOnly. Please use caching type None.",
2026-04-03T02:30:16.010555510Z "target": "dataDisk.caching"
2026-04-03T02:30:16.010555510Z }
2026-04-03T02:30:16.010555510Z }
2026-04-03T02:30:16.010555510Z --------------------------------------------------------------------------------
... |
3 participants
Summary
ultrassd-manifest.yamlwith VolumeAttributesClass support for runningKubernetes external storage e2e tests against the
managed-csi-ultrassdStorageClass.
volumeattributesclass.yamldefining an UltraSSD-backedVolumeAttributesClass with custom IOPS and throughput parameters