Skip to content

Updating golang-github-openshift-oauth-proxy-container image to be consistent with ART for 4.12#353

Open
ibihim wants to merge 2 commits intoopenshift:release-4.12from
ibihim:fix/gofmt-release-4.12
Open

Updating golang-github-openshift-oauth-proxy-container image to be consistent with ART for 4.12#353
ibihim wants to merge 2 commits intoopenshift:release-4.12from
ibihim:fix/gofmt-release-4.12

Conversation

@ibihim
Copy link
Copy Markdown

@ibihim ibihim commented Mar 15, 2026

Fixes gofmt for Go 1.19 doc comment formatting and includes ART image update for 4.12.

Go 1.19 changed gofmt rules requiring URLs in doc comment blocks to be on their own indented line.
This was causing ci/prow/verify to fail on the original ART PR.

Replaces #351.

ibihim added 2 commits March 15, 2026 23:41
Go 1.19 changed gofmt rules for doc comments, requiring URLs in
comment blocks to be on their own indented line.
…nsistent with ART for 4.12

Reconciling with ocp-build-data.
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 15, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 77a355d1-b579-468e-aab4-458cccac74f4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can generate a title for your PR based on the changes with custom instructions.

Set the reviews.auto_title_instructions setting to generate a title for your PR based on the changes in the PR with custom instructions.

@openshift-ci openshift-ci bot requested a review from deads2k March 15, 2026 22:42
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 15, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibihim
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 16, 2026

@ibihim: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant