-
Notifications
You must be signed in to change notification settings - Fork 1.9k
OSDOCS-17246 created doc for spire federation #103787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| // * security/zero_trust_workload_identity_manageer/zero-trust-manager-spire-federation.adoc | ||
|
|
||
| :_mod-docs-content-type: PROCEDURE | ||
| [id="zero-trust-manager-automatic-management{context}"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.IdHasContextVariable: ID is missing the '_{context}' variable at the end of the ID.
| // * security/zero_trust_workload_identity_manageer/zero-trust-manager-spire-federation.adoc | ||
|
|
||
| :_mod-docs-content-type: CONCEPT | ||
| [id="zero-trust-manager-config-example{context}"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.IdHasContextVariable: ID is missing the '_{context}' variable at the end of the ID.
| // * security/zero_trust_workload_identity_manageer/zero-trust-manager-spire-federation.adoc | ||
|
|
||
| :_mod-docs-content-type: CONCEPT | ||
| [id="zero-trust-manager-configure-endpoints{context}"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.IdHasContextVariable: ID is missing the '_{context}' variable at the end of the ID.
| // * security/zero_trust_workload_identity_manageer/zero-trust-manager-spire-federation.adoc | ||
|
|
||
| :_mod-docs-content-type: CONCEPT | ||
| [id="zero-trust-manager-federation-field-reference{context}"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.IdHasContextVariable: ID is missing the '_{context}' variable at the end of the ID.
| |Description | ||
|
|
||
| |`federation.bundleEndpoint.profile` | ||
| |enum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] RedHat.TermsErrors: Use 'data enumeration' rather than 'enum'. For more information, see RedHat.TermsErrors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enum is correct in this instance
| // * security/zero_trust_workload_identity_manageer/zero-trust-manager-spire-federation.adoc | ||
|
|
||
| :_mod-docs-content-type: PROCEDURE | ||
| [id="zero-trust-manager-manual-management{context}"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.IdHasContextVariable: ID is missing the '_{context}' variable at the end of the ID.
| $ oc --kubeconfig=/path/to/cluster3/kubeconfig apply -f - | ||
| ---- | ||
|
|
||
| The following is example output from running the command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.TaskStep: Content other than a single list cannot be mapped to DITA tasks.
8bda82c to
c5e1d35
Compare
anirudhAgniRedhat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this document , the way to setup the federation is explained via script. the script mentioned in the document is not customer facing and might not be shared with the customers.
Can we please update it and only explain the way to configure federation via spire server CR only
| spec: | ||
| # ... other configuration ... | ||
| federation: | ||
| ######################################################################### |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove these comments
| [source,terminal] | ||
| ---- | ||
| $ ./setup-3-cluster-federation-serving_cert.sh \ | ||
| -k1 /path/to/cluster1/kubeconfig \ | ||
| -k2 /path/to/cluster2/kubeconfig \ | ||
| -k3 /path/to/cluster3/kubeconfig \ | ||
| -c1 cluster1-name \ | ||
| -c2 cluster2-name \ | ||
| -c3 cluster3-name | ||
| ---- | ||
| + | ||
| The following is an example of a configured script. | ||
| + | ||
| [source,terminal] | ||
| ---- | ||
| $ ./setup-3-cluster-federation-serving_cert.sh \ | ||
| -k1 /home/rausingh/Documents/aws_cluster/08DecCluster1/auth/kubeconfig \ | ||
| -k2 /home/rausingh/Documents/aws_cluster/08DecCluster2/auth/kubeconfig \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not refer the script to configure the federation.
| @@ -0,0 +1,190 @@ | |||
| // Module included in the following assemblies: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file also refers to the script. Can we please remove this??
c5e1d35 to
bc1ed89
Compare
|
|
||
| * You have network connectivity between the clusters you intend to federate. | ||
|
|
||
| .Procedures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.TaskTitle: Unsupported titles cannot be mapped to DITA tasks.
|
|
||
| * You have network connectivity between the clusters you intend to federate. | ||
|
|
||
| .Procedures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.BlockTitle: Block titles can only be assigned to examples, figures, and tables in DITA.
|
|
||
| . Edit your `SpireServer` custom resource to add the `federation` section. | ||
| + | ||
| .Example YAML |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.BlockTitle: Block titles can only be assigned to examples, figures, and tables in DITA.
bc1ed89 to
12e686f
Compare
|
/cc @rausingh-rh for review |
|
@anirudhAgniRedhat: GitHub didn't allow me to request PR reviews from the following users: for, review. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cc @sayak-redhat for docs review as well |
|
@anirudhAgniRedhat: GitHub didn't allow me to request PR reviews from the following users: for, docs, review, as, well. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
|
||
| :_mod-docs-content-type: PROCEDURE | ||
| [id="zero-trust-manager-automatic-management_{context}"] | ||
| = Using SPIRE federation with Automatice Certificate Management (ACME) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| = Using SPIRE federation with Automatice Certificate Management (ACME) | |
| = Using SPIRE federation with Automatic Certificate Management Environment (ACME) |
typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
12e686f to
d91b1d0
Compare
|
|
||
| managedRoute: "true" # <7> | ||
| ---- | ||
| <1> Set a unique trust domain for each cluster (for example, `cluster1.example.com`, `cluster2.example.com`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.CalloutList: Callouts are not supported in DITA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| "spiffe_sequence": 1 | ||
| } | ||
| ---- | ||
| <1> Paste the complete trust bundle JSON content you fetched using `curl` in step 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.CalloutList: Callouts are not supported in DITA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| "spiffe_sequence": 1 | ||
| } | ||
| ---- | ||
| <1> The SPIFFE ID of the remote SPIRE server. Required for `https_spiffe` profile to validate the remote server's identity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.CalloutList: Callouts are not supported in DITA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
542ef07 to
02e078e
Compare
|
|
||
| * You have `cluster-admin` privileges on all participating clusters. | ||
|
|
||
| * You have installed the {cert-manager-operator}. For more information, see link:https://docs.redhat.com/en/documentation/openshift_container_platform/4.20/html/security_and_compliance/cert-manager-operator-for-red-hat-openshift[cert-manager Operator for Red Hat OpenShift]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{cert-manager-operator}' rather than the plain text product term 'cert-manager Operator for Red Hat OpenShift', unless your use case is an exception.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
stevsmit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a lot of feedback on this PR, and really most of it can be resolved in a separate PR. I am not typically a fan of asking people to do remediation work after something's been merged, but you seem to have a lot on your plate across multiple PRs. Normally I would require this stuff to be fixed before merging, but given the nature of how we do reviews now, it seems like it's crunch time for you.
(Keep in mind that if you ever have XXL PRs that are staged and ready for review, you can still send them to merge review and add the do-not-merge label, just so when it's release day you can quickly get someone to merge them without having an actual review done).
What you need to do before merging:
- Fix the mod_docs_content_type types where I've called them out. You have concept modules that are really reference modules, and reference modules that are really concept modules. I can honestly see how this can be confusing. So if you'll fix those, I'll merge this PR.
Post migration:
- Almost all callouts need formatted according to Andrea's team's guidelines here: https://docs.google.com/document/d/1j78SA8Y-ZRlVATbVe6D8bdYj7mQzzhOJtGt1xH_3qa0/edit?tab=t.0 .
- There are some minor nits like adding ". . . by running the following command:."
- There are a few instances where I think substep numbering would help
- Be sure to run the asciidoctor-dita-vale tool on subsequent PRs.
| = Using SPIRE federation with Automatic Certificate Management (ACME) | ||
|
|
||
| [role="_abstract"] | ||
| Using SPIRE federation with ACME provides automatic certificate provisioning from Let's Encrypt. ACME also enables automatic certificate renewal before expiration, eliminating manual certificate management overhead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Using SPIRE federation with ACME provides automatic certificate provisioning from Let's Encrypt. ACME also enables automatic certificate renewal before expiration, eliminating manual certificate management overhead. | |
| Using SPIRE federation with Automatic Certificate Management (ACME) provides automatic certificate provisioning from Let's Encrypt. ACME also enables automatic certificate renewal before expiration, eliminating manual certificate management overhead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| tosAccepted: "true" | ||
| managedRoute: "true" | ||
| ---- | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be like:
| + | |
| -- | |
| where: | |
| `trustDomain::` Set a unique trust domain for each cluster (for example, `cluster1.example.com`, `cluster2.example.com`) | |
| `<entry 2>` | |
| `<entry 3>` | |
| -- |
Technically some of these would start with "Specifies." See https://docs.google.com/document/d/1j78SA8Y-ZRlVATbVe6D8bdYj7mQzzhOJtGt1xH_3qa0/edit?tab=t.0#heading=h.vsfnqm21wp0r
Probably all need to end with periods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I redid all of this in the new format * The <replaceable value> field .. format
| trustDomain:: Set a unique trust domain for each cluster (for example, `cluster1.example.com`, `cluster2.example.com`) | ||
| profile:: Use `https_web` profile for ACME-based certificate management | ||
| directoryUrl:: Let's Encrypt production directory URL. For testing, use: `https://acme-staging-v02.api.letsencrypt.org/directory` | ||
| domainName:: The domain name where your federation endpoint will be accessible. This will be automatically set to `federation.<cluster-apps-domain>` if `managedRoute` is set to "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| domainName:: The domain name where your federation endpoint will be accessible. This will be automatically set to `federation.<cluster-apps-domain>` if `managedRoute` is set to "true" | |
| domainName:: The domain name where your federation endpoint will be accessible. This is automatically set to `federation.<cluster-apps-domain>` if `managedRoute` is set to "true". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| tosAccepted:: Accept Let's Encrypt Terms of Service | ||
| managedRoute:: Enable automatic route creation by the operator for the federation bundle endpoint | ||
|
|
||
| . Apply the configuration to each cluster: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| . Apply the configuration to each cluster: | |
| . Apply the configuration to each cluster by entering the following command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On all like this
| $ oc apply -f spireserver.yaml | ||
| ---- | ||
|
|
||
| . Wait for the SPIRE Server to be ready on each cluster: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| . Wait for the SPIRE Server to be ready on each cluster: | |
| . Check the status of the SPIRE Server by entering the following command. Wait for the `Ready` status to be returned before proceeding to the next step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
|
||
| [IMPORTANT] | ||
| ==== | ||
| Once enabled, federation cannot be disabled. The bundle endpoint profile is immutable once configured. Changing the profile or disabling federation requires reinstallation of the system. However, peer configurations (`federatesWith`) remain dynamic and can be added or removed at any time. Plan your profile selection carefully based on your long-term federation requirements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only use "once" when it's being used as "one time".
| Once enabled, federation cannot be disabled. The bundle endpoint profile is immutable once configured. Changing the profile or disabling federation requires reinstallation of the system. However, peer configurations (`federatesWith`) remain dynamic and can be added or removed at any time. Plan your profile selection carefully based on your long-term federation requirements. | |
| After enablement, federation cannot be disabled. The bundle endpoint profile is immutable once configured. Changing the profile or disabling federation requires reinstallation of the system. However, peer configurations (`federatesWith`) remain dynamic and can be added or removed at any time. Plan your profile selection carefully based on your long-term federation requirements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| refreshHint: 300 | ||
| managedRoute: "true" | ||
| ---- | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| + | |
| -- | |
| where: | |
| <entry> | |
| -- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New format
|
|
||
| [source,terminal] | ||
| ---- | ||
| $ curl -k https://federation.apps.cluster2.example.com > cluster2-bundle.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general we try not to have code blocks in notes. We could just make it another line and move it out of the NOTE box.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved code outside of annotation
|
|
||
| . Create `ClusterFederatedTrustDomain` resources for each remote trust domain. | ||
| + | ||
| On Cluster 1, create a resource to federate with Cluster 2: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| On Cluster 1, create a resource to federate with Cluster 2: | |
| .. On Cluster 1, create a resource to federate with Cluster 2: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| // | ||
| // * security/zero_trust_workload_identity_manager/zero-trust-manager-spire-federation.adoc | ||
|
|
||
| :_mod-docs-content-type: CONCEPT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably more of a REFERENCE module (even has REFERENCE in the title :D )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
02e078e to
fb5c75e
Compare
|
|
||
| * You have `cluster-admin` privileges on all participating clusters. | ||
|
|
||
| * You have installed the {cert-manager-operator}. For more information, see link:https://docs.redhat.com/en/documentation/openshift_container_platform/4.20/html/security_and_compliance/cert-manager-operator-for-red-hat-openshift[cert-manager Operator for Red Hat OpenShift]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{cert-manager-operator}' rather than the plain text product term 'cert-manager Operator for Red Hat OpenShift', unless your use case is an exception.
|
lgtm |
sayak-redhat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
| metadata: | ||
| name: cluster | ||
| namespace: zero-trust-workload-identity-manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| metadata: | |
| name: cluster | |
| namespace: zero-trust-workload-identity-manager | |
| metadata: | |
| name: cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| metadata: | ||
| name: cluster | ||
| namespace: zero-trust-workload-identity-manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| metadata: | |
| name: cluster | |
| namespace: zero-trust-workload-identity-manager | |
| metadata: | |
| name: cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| metadata: | ||
| name: cluster | ||
| namespace: zero-trust-workload-identity-manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| metadata: | |
| name: cluster | |
| namespace: zero-trust-workload-identity-manager | |
| metadata: | |
| name: cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| metadata: | ||
| name: cluster | ||
| namespace: zero-trust-workload-identity-manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| metadata: | |
| name: cluster | |
| namespace: zero-trust-workload-identity-manager | |
| metadata: | |
| name: cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| - trustDomain: partner.example.com | ||
| bundleEndpointUrl: https://federation.partner.example.com | ||
| bundleEndpointProfile: https_web | ||
| #Another external partner using Web PKI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| #Another external partner using Web PKI | |
| # Another external partner using Web PKI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| metadata: | ||
| name: cluster | ||
| namespace: zero-trust-workload-identity-manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| metadata: | |
| name: cluster | |
| namespace: zero-trust-workload-identity-manager | |
| metadata: | |
| name: cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| metadata: | ||
| name: cluster | ||
| namespace: zero-trust-workload-identity-manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| metadata: | |
| name: cluster | |
| namespace: zero-trust-workload-identity-manager | |
| metadata: | |
| name: cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| + | ||
| [source,terminal] | ||
| ---- | ||
| $ oc get spireserver cluster -n zero-trust-workload-identity-manager -w |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| $ oc get spireserver cluster -n zero-trust-workload-identity-manager -w | |
| $ oc get spireserver cluster -w |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| . Wait for the SPIRE Server to be ready: | ||
| + | ||
| [source,terminal] | ||
| ---- | ||
| $ oc get spireserver cluster -n zero-trust-workload-identity-manager -w | ||
| ---- | ||
| + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| . Wait for the SPIRE Server to be ready: | |
| + | |
| [source,terminal] | |
| ---- | |
| $ oc get spireserver cluster -n zero-trust-workload-identity-manager -w | |
| ---- | |
| + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| + | ||
| [source,terminal] | ||
| ---- | ||
| $ oc get spireserver cluster -n zero-trust-workload-identity-manager -w |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| $ oc get spireserver cluster -n zero-trust-workload-identity-manager -w | |
| $ oc get spireserver cluster -w |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
|
||
| :_mod-docs-content-type: PROCEDURE | ||
| [id="zero-trust-manager-automatic-management_{context}"] | ||
| = Using SPIRE federation with Automatic Certificate Management |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| = Using SPIRE federation with Automatic Certificate Management | |
| = Using SPIRE federation with Automatic Certificate Management Environment protocol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| = Using SPIRE federation with Automatic Certificate Management | ||
|
|
||
| [role="_abstract"] | ||
| Using SPIRE federation with Automatic Certificate Management (ACME) provides automatic certificate provisioning from Let's Encrypt. ACME also enables automatic certificate renewal before expiration, eliminating manual certificate management overhead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Using SPIRE federation with Automatic Certificate Management (ACME) provides automatic certificate provisioning from Let's Encrypt. ACME also enables automatic certificate renewal before expiration, eliminating manual certificate management overhead. | |
| Using SPIRE federation with Automatic Certificate Management Environment (ACME) protocol provides automatic certificate provisioning from Let's Encrypt. ACME also enables automatic certificate renewal before expiration, eliminating manual certificate management overhead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
fb5c75e to
409a00d
Compare
|
|
||
| * You have `cluster-admin` privileges on all participating clusters. | ||
|
|
||
| * You have installed the {cert-manager-operator}. For more information, see link:https://docs.redhat.com/en/documentation/openshift_container_platform/4.20/html/security_and_compliance/cert-manager-operator-for-red-hat-openshift[cert-manager Operator for Red Hat OpenShift]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{cert-manager-operator}' rather than the plain text product term 'cert-manager Operator for Red Hat OpenShift', unless your use case is an exception.
409a00d to
064bd50
Compare
|
|
||
| * You have `cluster-admin` privileges on all participating clusters. | ||
|
|
||
| * You have installed the {cert-manager-operator}. For more information, see link:https://docs.redhat.com/en/documentation/openshift_container_platform/4.20/html/security_and_compliance/cert-manager-operator-for-red-hat-openshift[cert-manager Operator for Red Hat OpenShift]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{cert-manager-operator}' rather than the plain text product term 'cert-manager Operator for Red Hat OpenShift', unless your use case is an exception.
| $ curl -k https://federation.apps.cluster2.example.com > cluster2-bundle.json | ||
| ---- | ||
| + | ||
| The response contains the trust bundle in JSON Web Key Set (JWKS) format: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
064bd50 to
7d67fda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.ShortDescription: Assign [role="_abstract"] to a paragraph to use it as in DITA.
|
|
||
| * You have `cluster-admin` privileges on all participating clusters. | ||
|
|
||
| * You have installed the {cert-manager-operator}. For more information, see link:https://docs.redhat.com/en/documentation/openshift_container_platform/4.20/html/security_and_compliance/cert-manager-operator-for-red-hat-openshift[cert-manager Operator for Red Hat OpenShift]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{cert-manager-operator}' rather than the plain text product term 'cert-manager Operator for Red Hat OpenShift', unless your use case is an exception.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.ShortDescription: Assign [role="_abstract"] to a paragraph to use it as in DITA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.ShortDescription: Assign [role="_abstract"] to a paragraph to use it as in DITA.
|
@wgabor0427: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Merging under the conditions that there are still a few ADV errors that need resolved in a follow up PR. |
|
/cherry-pick enterprise-4.21 |
|
/cherry-pick enterprise-4.20 |
|
@stevsmit: new pull request created: #104191 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@stevsmit: new pull request created: #104192 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |

Version(s):
4.20+
Issue:
https://issues.redhat.com/browse/OSDOCS-17246
Link to docs preview:
QE review:
Additional information: