Skip to content

Conversation

@GroceryBoyJr
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr commented Dec 11, 2025

Version(s):

Issue: https://issues.redhat.com/browse/CMP-4011

Link to docs preview: https://103789--ocpdocs-pr.netlify.app/openshift-enterprise/latest/welcome/

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2025

@GroceryBoyJr: This pull request references CMP-4011 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

… Operator CEL

Version(s):

Issue: https://issues.redhat.com/browse/CMP-4011

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 11, 2025
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 11, 2025
@GroceryBoyJr GroceryBoyJr changed the title CMP-4011: Document Custom OpenShift Compliance Scans using Compliance… CMP-4011: Document Custom OpenShift Compliance Scans Dec 11, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2025

@GroceryBoyJr: This pull request references CMP-4011 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Version(s):

Issue: https://issues.redhat.com/browse/CMP-4011

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gaurav-nelson
Copy link
Contributor

/retest

@GroceryBoyJr GroceryBoyJr force-pushed the cmp-4011 branch 6 times, most recently from 9a05bfc to 69cf0fc Compare December 11, 2025 21:11
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2025

@GroceryBoyJr: This pull request references CMP-4011 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Version(s):

Issue: https://issues.redhat.com/browse/CMP-4011

Link to docs preview: https://103789--ocpdocs-pr.netlify.app/openshift-enterprise/latest/welcome/

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@GroceryBoyJr GroceryBoyJr force-pushed the cmp-4011 branch 3 times, most recently from 91a3f36 to 5b9c98b Compare December 11, 2025 22:09
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 11, 2025
@GroceryBoyJr GroceryBoyJr force-pushed the cmp-4011 branch 2 times, most recently from 5452596 to 1b8a9aa Compare December 11, 2025 22:38
@openshift-ci
Copy link

openshift-ci bot commented Dec 11, 2025

@GroceryBoyJr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate-portal 19340db link true /test validate-portal

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

apiVersion: observability.openshift.io/v1
resource: clusterlogforwarders
expression: |
clusterLogForwarderList.items.items.size() > 0 &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be clusterLogForwarderList.items.size() > 0 &&

NAME STATUS SEVERITY
logging-security-checks-clusterlogforwarder-secure-endpoints FAIL High

Step 5: Identify and fix non-compliant resources
Copy link
Contributor

@xiaojiey xiaojiey Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the step 5 might not needed. You put too much time on the rule details. Actually the KCS is already available. Maybe you can change to another customrule as an example. And Focus on the customrule resource itself.

Create a file named `clusterlogforwarder-secure-endpoints.yaml:`

apiVersion: compliance.openshift.io/v1alpha1
kind: CustomRule
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe annotaion needed to highlight this is CustomRule.

and do not set tls.insecureSkipVerify=true.
severity: High
checkType: Platform
scannerType: CEL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe annotaion needed to highlight the scannerType is CEL.

@xiaojiey
Copy link
Contributor

xiaojiey commented Jan 4, 2026

I think you also need to highlight the feature is tach preview status, only platform type customrule needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants