OCPBUGS-74406: Check required credentials in a detailed way

[mabulgu]

Improve Redfish VirtualMedia InsertMedia error handling on BMCs that require credentials but return unstructured errors (e.g., responses that omit error.code and report ActionParameterMissing only via @Message.ExtendedInfo or free-text messages). Sushy now detects these cases and retries with UserName/Password parameters, allowing ISO mounting to proceed. This also preserves compatibility with legacy error.code == *GeneralError responses that mention missing parameters.

Change-Id: Ie65d70a7862f4cc7058269921bc512a8a9754bae

Assisted-By: Claude

[openshift-ci-robot]

@mabulgu: This pull request references Jira Issue OCPBUGS-74406, which is invalid:

• expected Jira Issue OCPBUGS-74406 to depend on a bug targeting a version in 4.20.0, 4.20.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Improve Redfish VirtualMedia InsertMedia error handling on BMCs that require credentials but return unstructured errors (e.g., responses that omit error.code and report ActionParameterMissing only via @Message.ExtendedInfo or free-text messages). Sushy now detects these cases and retries with UserName/Password parameters, allowing ISO mounting to proceed. This also preserves compatibility with legacy error.code == *GeneralError responses that mention missing parameters.

Change-Id: Ie65d70a7862f4cc7058269921bc512a8a9754bae

Assisted-By: chatgpt-5 (for research purposes)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[mabulgu]

/jira refresh

[openshift-ci-robot]

@mabulgu: This pull request references Jira Issue OCPBUGS-74406, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.z) matches configured target version for branch (4.19.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-74405 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-74405 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
• bug has dependents

Requesting review from QA contact:
/cc @jadhaj

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@mabulgu: This pull request references Jira Issue OCPBUGS-74406, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.z) matches configured target version for branch (4.19.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-74405 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-74405 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
• bug has dependents

Requesting review from QA contact:
/cc @jadhaj

Details

In response to this:

Improve Redfish VirtualMedia InsertMedia error handling on BMCs that require credentials but return unstructured errors (e.g., responses that omit error.code and report ActionParameterMissing only via @Message.ExtendedInfo or free-text messages). Sushy now detects these cases and retries with UserName/Password parameters, allowing ISO mounting to proceed. This also preserves compatibility with legacy error.code == *GeneralError responses that mention missing parameters.

Change-Id: Ie65d70a7862f4cc7058269921bc512a8a9754bae

Assisted-By: Claude

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@mabulgu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[elfosardo]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, mabulgu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [elfosardo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@mabulgu: Jira Issue OCPBUGS-74406: All pull requests linked via external trackers have merged:

• openshift/openstack-sushy#144

Jira Issue OCPBUGS-74406 has been moved to the MODIFIED state.

Details

In response to this:

Improve Redfish VirtualMedia InsertMedia error handling on BMCs that require credentials but return unstructured errors (e.g., responses that omit error.code and report ActionParameterMissing only via @Message.ExtendedInfo or free-text messages). Sushy now detects these cases and retries with UserName/Password parameters, allowing ISO mounting to proceed. This also preserves compatibility with legacy error.code == *GeneralError responses that mention missing parameters.

Change-Id: Ie65d70a7862f4cc7058269921bc512a8a9754bae

Assisted-By: Claude

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.