Skip to content

Conversation

@prozehna
Copy link

@prozehna prozehna commented Dec 3, 2025

Tagging @cpmeadors for visibility.

Simple PR -

  1. touched the folder is where our go tests will migrate to,
  2. touched the OWNERS file.

As per Owners///the owners file, I was going to have everyone be a reviewer and approver, but I accidentally used a older file. In any case, who, perhaps everyone, should be a reviewer & maintainer

@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci bot requested review from deads2k and p0lyn0mial December 3, 2025 19:13
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prozehna
Once this PR has been reviewed and has the lgtm label, please assign xueqzhan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Dec 3, 2025
@@ -0,0 +1,5 @@
reviewers:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prozehna Shouldn't you be in this list as well? Everyone on this team/contributes to this component should be in the OWNERS.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, my PR actually took an older version of my owners file. I updated that.

@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@elmiko
Copy link
Contributor

elmiko commented Dec 4, 2025

looks like the github names are incorrect here, they should be @joelsmith and @maxcao13 , additionally should i be on these?

@elmiko
Copy link
Contributor

elmiko commented Dec 4, 2025

here's an owners file we use for reference, https://github.com/openshift/kubernetes-autoscaler/blob/main/OWNERS

Owner handles refer to github handles, not redhat (email) handles.
@openshift-ci openshift-ci bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Dec 4, 2025
Copy link
Author

@prozehna prozehna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Owner handles refer to github accounts, not redhat emails.

@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@prozehna
Copy link
Author

prozehna commented Dec 4, 2025

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 4, 2025

@prozehna: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants