-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Folder for autoscale migration && OWNERS file #30566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: prozehna The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
test/extended/autoscale/OWNERS
Outdated
| @@ -0,0 +1,5 @@ | |||
| reviewers: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prozehna Shouldn't you be in this list as well? Everyone on this team/contributes to this component should be in the OWNERS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, my PR actually took an older version of my owners file. I updated that.
|
Scheduling required tests: |
|
looks like the github names are incorrect here, they should be @joelsmith and @maxcao13 , additionally should i be on these? |
|
here's an owners file we use for reference, https://github.com/openshift/kubernetes-autoscaler/blob/main/OWNERS |
Owner handles refer to github handles, not redhat (email) handles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Owner handles refer to github accounts, not redhat emails.
|
Scheduling required tests: |
|
/retest |
|
@prozehna: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Tagging @cpmeadors for visibility.
Simple PR -
As per Owners///the owners file, I was going to have everyone be a reviewer and approver, but I accidentally used a older file. In any case, who, perhaps everyone, should be a reviewer & maintainer