OCPBUGS-78110: [release-4.12] hermetic 4.12#744
OCPBUGS-78110: [release-4.12] hermetic 4.12#744fgallott wants to merge 1 commit intoopenshift:release-4.12from
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@fgallott: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/jira cherrypick OCPBUGS-78109 |
|
@fgallott: Jira Issue OCPBUGS-78109 has been cloned as Jira Issue OCPBUGS-78110. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/invalid-bug
|
@fgallott: This pull request references Jira Issue OCPBUGS-78110, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use OpenGrep to find security vulnerabilities and bugs across 17+ programming languages.OpenGrep is compatible with Semgrep configurations. Add an |
|
/retest-required |
|
/retitle OCPBUGS-78110: [release-4.12] hermetic 4.12 |
openshift-ci
bot
changed the title
|
Can you please 1) squash/fixup commits into a single one, 2) reference Jira bug in the commit message too, 3) explain more why the change is needed for hermetic build in the commit message too? |
Hermetic builds require that all dependencies are vendored and that the vendor directory is fully consistent with go.mod. The build was failing with: Error: PackageRejected: The content of the vendor directory is not consistent with go.mod. This was caused by a missing file (vendor/github.com/getsentry/ raven-go/Dockerfile.test) which was likely excluded by a .gitignore rule matching "Dockerfile*". Running `go mod vendor` restores this file, and it must be committed with `git add --force` to satisfy the hermetic build's vendor consistency check. Additionally, test certificates in validation_test.go and plugin_test.go were regenerated because they had expired, which caused unit test failures. rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
done |
|
@fgallott: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/assign @alebedev87 |
4 participants
same as #743