Skip to content

fix: horizontal scrollbars are not correctly aligned#1053

Merged
mehah merged 4 commits intoopentibiabr:mainfrom
lucasoares:fix-horiontal-scroll
Jan 18, 2025
Merged

fix: horizontal scrollbars are not correctly aligned#1053
mehah merged 4 commits intoopentibiabr:mainfrom
lucasoares:fix-horiontal-scroll

Conversation

@lucasoares
Copy link
Copy Markdown
Contributor

@lucasoares lucasoares commented Jan 16, 2025

Description

Even after #1040 and #1036, the horizontal scrollbars are not correctly aligned.

I ask you all to help testing this before merging, because the last PR on scrolls I made, everything was working for me but still some scrollbars got mixed up. @nekiro please review the changes, since you made the last change.

Thanks.

Before:
image

After:
image

(#1040 (comment))

Also the marked scrollbar was not aligned too:

Before:
image

After:
image

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

@sonarqubecloud
Copy link
Copy Markdown

@mehah mehah requested review from Nottinghster, kokekanon, luanluciano93 and nekiro and removed request for Nottinghster January 18, 2025 02:58
Copy link
Copy Markdown
Contributor

@kokekanon kokekanon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very detail-oriented(To spot that, i need a magnifying glass, xd), but it doesn't break anything

@mehah mehah merged commit cc098c9 into opentibiabr:main Jan 18, 2025
@lucasoares
Copy link
Copy Markdown
Contributor Author

I'm not very detail-oriented(To spot that, i need a magnifying glass, xd), but it doesn't break anything

hahahaha these little details makes me very sad, so I will fix them all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants