Skip to content

fix: bestiary progress bar clipping#1102

Merged
mehah merged 1 commit intoopentibiabr:mainfrom
DanielChabrowski:fix-bestiary-clipping
Feb 19, 2025
Merged

fix: bestiary progress bar clipping#1102
mehah merged 1 commit intoopentibiabr:mainfrom
DanielChabrowski:fix-bestiary-clipping

Conversation

@DanielChabrowski
Copy link
Contributor

Description

Kill count is so small for the second progress stage, the calculations return width = 0 which breaks setImageRect. Using similar fix as in the bosstiary

Behavior

Actual

image

Expected

image

Fixes

# Bestiary progress bar clipping

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version: tfs master + patches
  • Client: mehah + patches
  • Operating System: Linux

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@sonarqubecloud
Copy link

@mehah mehah merged commit 25f8f9c into opentibiabr:main Feb 19, 2025
12 checks passed
@DanielChabrowski DanielChabrowski deleted the fix-bestiary-clipping branch February 19, 2025 17:53
vllsystems pushed a commit to vllsystems/otclient that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants