Skip to content

feat: Quest Log tracker and Style 14.10 in html/css#1144

Merged
mehah merged 16 commits intoopentibiabr:mainfrom
kokekanon:kokekanon/questlog
May 7, 2025
Merged

feat: Quest Log tracker and Style 14.10 in html/css#1144
mehah merged 16 commits intoopentibiabr:mainfrom
kokekanon:kokekanon/questlog

Conversation

@kokekanon
Copy link
Copy Markdown
Contributor

@kokekanon kokekanon commented Apr 29, 2025 •
edited
Loading

Description

image

image

note:

  • untest
  • I have nowhere to test 14.10
  • My knowledge of HTML/CSS is quite limited.

This PR is in DRAFT due to the necessary modifications:

  • fix Json
  • fix pin
  • fix hidden
  • test packets 14.10
  • comboBox
  • onkeyDown / onKeyUp

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

no test

Test Configuration:

  • Server Version: 13.10
  • Client: this pr
  • Operating System: windows

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

luanluciano93
luanluciano93 reviewed Apr 29, 2025
View reviewed changes
@kokekanon kokekanon marked this pull request as ready for review May 7, 2025 22:37
@mehah mehah merged commit a96ad48 into opentibiabr:main May 7, 2025
12 checks passed
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented May 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Nottinghster added a commit that referenced this pull request May 21, 2025
@Nottinghster
fix: quest log (pr #1144)
1e31112 
ERROR: failed to create widget from style 'QuestLogLabel': 'CheckBoxButton' is not a defined style
ERROR: Lua exception: /game_questlog/game_questlog.lua:181: attempt to index local 'item' (a nil value)
stack traceback:
    [C]: in function '__index'
    /game_questlog/game_questlog.lua:181: in function 'createQuestItem'
    /game_questlog/game_questlog.lua:449: in function </game_questlog/game_questlog.lua:432>
ERROR: protected lua call failed: LUA ERROR:
/game_questlog/game_questlog.lua:181: attempt to index local 'item' (a nil value)
stack traceback:
    [C]: in function '__index'
    /game_questlog/game_questlog.lua:181: in function 'createQuestItem'
    /game_questlog/game_questlog.lua:449: in function </game_questlog/game_questlog.lua:432>
@Nottinghster Nottinghster mentioned this pull request May 21, 2025
Merged
kokekanon added a commit that referenced this pull request May 22, 2025
@kokekanon
Revert "fix: quest log (pr #1144)"
14d0e0e 
This reverts commit 1e31112.
mehah pushed a commit that referenced this pull request May 23, 2025
@Nottinghster
fix: quest log (pr #1144) (#1164)
2af1c2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@luanluciano93 luanluciano93 luanluciano93 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kokekanon @luanluciano93 @mehah