Skip to content

feat: add title bar color customization for Windows#1258

Merged
mehah merged 2 commits intoopentibiabr:mainfrom
libergod:colored-windows-topbar
Aug 6, 2025
Merged

feat: add title bar color customization for Windows#1258
mehah merged 2 commits intoopentibiabr:mainfrom
libergod:colored-windows-topbar

Conversation

@libergod
Copy link
Copy Markdown
Collaborator

Description

Enables colored color on the Window Top bar.
image

Behavior

Actual

Do this and that doesn't happens

Expected

Do this and that happens

Fixes

# (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version: Canary 14
  • Client: OTCLIENT
  • Operating System: WINDOWS 11

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@libergod libergod marked this pull request as ready for review July 30, 2025 16:48
@patrykq112
Copy link
Copy Markdown

How about compatibility with older Windows systems?

@SkullzOTS
Copy link
Copy Markdown
Contributor

SkullzOTS commented Jul 30, 2025

patrykq112

I think it didn't even work anymore and it's been a while... a message appeared with something about CreateFile2 in Windows 7

Since 2022, redemption has not worked on Windows 7, as that was when I launched my first OTServ and I had several reports of this.

@libergod
Copy link
Copy Markdown
Collaborator Author

libergod commented Jul 30, 2025

How about compatibility with older Windows systems?

Already being treated... check file src/framework/platform/win32window.cpp

If not supported, will do nothing, just log.

@kokekanon
Copy link
Copy Markdown
Contributor

test in windows 8
Sin título

test in windows 11

image

idk in client linux or web

@libergod
Copy link
Copy Markdown
Collaborator Author

libergod commented Jul 31, 2025

test in windows 8 Sin título

test in windows 11

image idk in client linux or web

Looks fantastic to me. The text of the bar to the left side is already defaulted to the OTClient on Windows 11, as per my understanding, as well as the middle alignment to Windows 8.

Question: Windows 8 should also be able to change colour? What is the actual behaviour of Tibia Global Client on Windows 8?

@libergod libergod force-pushed the colored-windows-topbar branch from 38b65c8 to c58d244 Compare July 31, 2025 23:46
@sonarqubecloud
Copy link
Copy Markdown

@kokekanon
Copy link
Copy Markdown
Contributor

kokekanon commented Aug 1, 2025

image

I'll try it later, that pc runs on coal.

edit: nope. cipsoft no open en windows 8 "Tibia cannot be started"

@libergod libergod force-pushed the colored-windows-topbar branch from c58d244 to 1f90c31 Compare August 2, 2025 16:46
@mehah
Copy link
Copy Markdown
Collaborator

mehah commented Aug 3, 2025

is done?

@libergod
Copy link
Copy Markdown
Collaborator Author

libergod commented Aug 5, 2025

From my perspective, it is done.

Works on W11, doesn't work on W8 (Keep it as is). Haven't tested on W10/linux.

Copy link
Copy Markdown
Contributor

@kokekanon kokekanon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test in Windows 11, Windows 8

@mehah mehah merged commit 40329dd into opentibiabr:main Aug 6, 2025
11 checks passed
@libergod libergod deleted the colored-windows-topbar branch August 6, 2025 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants