fix: auto loot distance check with version-specific corpse mechanics

[Copilot]

Fix vBot_4.8 auto loot corpse distance issue

The issue: vBot thinks corpses are lootable without being adjacent (touching) them. On Tibia 7.6, you must be at distance 1 (adjacent) to loot corpses:

Root cause: The looting code didn't account for version differences. CipSoft added support for looting corpses from larger distance at some point after version 760.

Changes made:

• Made distance check version-specific using g_game.getClientVersion()
• For version 760 and earlier: requires distance 1 (adjacent) with walk precision 1
• For versions after 760: allows distance 2 with walk precision 2 (maintains original behavior)
• Uses clear coding style: defaults set first, then overridden for older versions
• Added comment noting that 760 is approximate cutoff (exact version unknown)
• Applied fix to both vBot_4.8 and cavebot_1.3

Files modified:

• mods/game_bot/default_configs/vBot_4.8/targetbot/looting.lua
• mods/game_bot/default_configs/cavebot_1.3/targetbot/looting.lua

Plan:

• Analyze the looting code in vBot_4.8/targetbot/looting.lua
• Make distance check version-specific (<=760 requires adjacency, >760 allows distance 2)
• Apply same fix to cavebot_1.3
• Refactor to use clearer coding style
• Fix default value to match original behavior
• Run code review
• Run security scan

Security Summary: No security vulnerabilities introduced. These are configuration changes to Lua bot scripts that only affect game behavior based on client version.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>vBot_4.8 auto loot think corpses are lootable without touching</issue_title>
<issue_description>### Priority

Medium

Area

• Data
• Source
• Docker
• Other

What happened?

vBot_4.8 auto loot think corpses are lootable without touching.

On tibia7.6, they are not. The auto looter sometimes get stuck trying to loot corpses without touching them:

What OS are you seeing the problem on?

Windows

Code of Conduct

• I agree to follow this project's Code of Conduct</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes vBot_4.8 auto loot think corpses are lootable without touching #1524

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[divinity76]

At some point, CipSoft added support for looting corpses without adjacency. I don't know when they did that, but it was after 760.

The code should do something like

if g_game.getClientVersion() <= 760 then
...
with a note 760 is probably not the correct cutoff either, but we don't know the correct cutoff (we only know it's > 760)

unless you happen to know when cipsoft did it.

[divinity76]

I don't like the coding style. Try something like

  local minDist = 3
  local walkPrecision = 2
  if g_game.getClientVersion() <= 760 then
  -- Later versions allow looting from larger distance. We use 760 as cutoff, but the exact
  -- version when CipSoft changed this is unknown
    minDist = 1
  walkPrecision = 1
  end
  if dist > minDist or not tile then

[Copilot]

I don't like the coding style. Try something like

  local minDist = 3

...

Updated in commit d1db0ac. Changed to the requested coding style with defaults set first (minDist = 2, walkPrecision = 2), then overridden for version <= 760 (minDist = 1, walkPrecision = 1).

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[javiertringol]

hey @copilot Do you think these issues and pull requests should be in divinity76’s repository instead of the main repository?
And once everything is 100% ready, should the pull request be sent to the main repository?

[divinity76]

@javiertringol I see your point, I think the way to achieve that is to copy-paste the issue to the local repo, then assign copilot in that repo, fix it, and then send a PR. Clunky but yeah.

Anyway, the code LGTM now, I haven't actually tested it (and it's 4am, i won't be able to test it for another 10 hours I think),
But it looks correct.

Marked as ready-for-review

[divinity76]

btw does anyone know when Cip added that "you don't need to stand right next to the body" thing?

[divinity76]

Have tested it.
Unsurprisingly, the code is correct.

auto looter no longer get stuck on 7.6 👍

my recommendation, ship it.

ping @kokekanon need a 2nd reviewer to approve for Copilot PRs.

[Zbizu]

btw does anyone know when Cip added that "you don't need to stand right next to the body" thing?

in 13.40 they made it possible to loot all corpses in exori range with one click. Just tested it on cip servers and I had to walk to the monster corpse in order to quick loot it. Might be ots-only thing (or premium account feature).

[divinity76]

Just tested it on cip servers and I had to walk to the monster corpse in order to quick loot it. Might be ots-only thing (or premium account feature).

Oh wow, in that case, I'm in favor of removing the version guard entirely and make the bot always enter exori range to loot. Is "vBot getting stuck on auto-loot" a well-known problem? Does it happen in like 10.x versions too?

in 13.40 they made it possible to loot all corpses in exori range with one click.

Neat. Does Cipsoft let you implement blacklist to ignore trash/stuff you're not interested in? I have not been on Cipsoft servers in many years

[divinity76]

quoting https://forum.gunzodus.net/threads/is-there-an-option-to-loot-from-distance.143/

I mean like real tibia, you can autoloot being away from the corpse, is it possible or do I have to right click everytime i kill a monster? Thank you! If not possible, why not add this? Thanks GMs and CEO for answering.

Which suggest that, at least in 2019, Cipsoft's tibia allowed autoloot to loot away from corpses 🤔

I also recall BlackD Proxy's cavebot adding more-distant-than-exori-range looting at some point, and breaking 7.6 looting in the process (7.6 was later fixed)

[Zbizu]

Neat. Does Cipsoft let you implement blacklist to ignore trash/stuff you're not interested in? I have not been on Cipsoft servers in many years

yes, there are two modes, one is collecting defined items only, the other mode does exact opposite
the client limit is something like 250 items, even when the server allows more

[HopeItBuilds]

quoting https://forum.gunzodus.net/threads/is-there-an-option-to-loot-from-distance.143/

I mean like real tibia, you can autoloot being away from the corpse, is it possible or do I have to right click everytime i kill a monster? Thank you! If not possible, why not add this? Thanks GMs and CEO for answering.

Which suggest that, at least in 2019, Cipsoft's tibia allowed autoloot to loot away from corpses 🤔

I also recall BlackD Proxy's cavebot adding more-distant-than-exori-range looting at some point, and breaking 7.6 looting in the process (7.6 was later fixed)

I know this is two weeks old but as I never stopped playing real tibia, I can say for sure that it was NEVER POSSIBLE to loot from distance, also, in real tibia we don't have "auto loot" but "quick loot", and yes the corpse should always be in your range in order for the quick loot to work, because you still have to click the corpse

there was never a premium feature or anything like that, that allowed autoloot from distance, this gunzodus post is totally shit

[divinity76]

Well does anybody want to craft a PR to remove the version check for the distance looting fix?