Skip to content

fix(#1596): rect of creature drawInformation bar #1597

Merged
Nottinghster merged 1 commit intoopentibiabr:mainfrom
kokekanon:fixhealth
Jan 14, 2026
Merged

fix(#1596): rect of creature drawInformation bar #1597
Nottinghster merged 1 commit intoopentibiabr:mainfrom
kokekanon:fixhealth

Conversation

@kokekanon
Copy link
Copy Markdown
Contributor

@kokekanon kokekanon commented Jan 14, 2026

Increased the width of health, mana, and mana shield bars from 25 to 29 and shifted the background and icon positions by 2 units for better alignment and visual consistency in the creature information display.

image

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Behavior

Actual

image

Expected

image

Fixes

#1596

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version:
  • Client:
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Summary by CodeRabbit

  • Style
    • Refined creature information bar layout and adjusted health/mana bar sizing for improved visual presentation.

✏️ Tip: You can customize this high-level summary in your review settings.

Increased the width of health, mana, and mana shield bars from 25 to 29 and shifted the background and icon positions by 2 units for better alignment and visual consistency in the creature information display.
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 14, 2026

📝 Walkthrough

Walkthrough

UI layout adjustment in creature rendering that shifts information-bar elements two pixels rightward via x-offset changes (13.5 to 15.5) and increases health/mana bar widths from 25 to 29 pixels for improved visual spacing.

Changes

Cohort / File(s) Summary
UI Element Positioning & Bar Sizing
src/client/creature.cpp
Adjusted horizontal x-offsets for skull, shield, emblem, type, and icon rendering from 13.5 to 15.5; increased health/mana bar widths from 25 to 29; shifted background rectangle origin alignment; modified icon batch rendering destination coordinates.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A hop to the right, two pixels so slight,
Health bars grow plump, mana bars bright,
Icons align with a shuffle and slide,
The creature display now sits with more pride!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: fixing the rectangle positioning of the creature's drawInformation bar, which aligns with the code modifications that adjust UI element positions and bar sizing.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@kokekanon
Copy link
Copy Markdown
Contributor Author

This bug is also in the recently released version.
ups.

@Nottinghster Nottinghster merged commit e8008af into opentibiabr:main Jan 14, 2026
8 checks passed
@mehah mehah deleted the fixhealth branch January 14, 2026 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants