Conversation
There was a problem hiding this comment.
The contribution is very good, congratulations, I just have a few small suggestions to make.
In some places the end line is missing, I also saw an exception that is handled but has no behaviour inside it, it would be interesting to put it in my view, as it facilitates debugging.
tuliomagalhaes
left a comment
There was a problem hiding this comment.
Amazing work! Thanks for doing this! 🚀
|
Amazing pull request! I would suggest editting INT_MAX to a more c++ approach using std::numeric_limits::max |
|
LGTM 🚀 |
|
Added supported devices to modules, now we can load modules specific to different devices. In this example this module will only load on |
|
@mehah This is completed now. Revisions might come later, but I think its in a good state to merge if you're happy with it. |
|
Amazing!!! Thanks for contributing. |
Adaptive UI Loading
The goal of this feature is to provide an efficient way to load the UI on the device running the client.
How does it work?
I've introduced a new data structure for defining the users device:
Using this I will dynamically load data resources from their respective directory, this is handled in two ways:
deviceand/orosdirectoriesThis will load the resource files in the given order and override
main widgetfrom which ever otui file contains it, using the same priority flow as above.I have provided a simple example in this pull request. With this system we can start building different user interfaces for the different devices.
Some other notable changes in this PR:
max-sizeLogFinefor more granular logging requirementsm_levelto the Logger to specify what log level you want to use output (level >= m_level -> log(...))onPropertyChangelua call toUIWidget::setPropI am only really looking for feedback from maintainers.
Checklist