fix: spells cooldown if UINT16 is expected#542
Merged
mehah merged 2 commits intoopentibiabr:mainfrom Jun 2, 2023
Merged
Conversation
Collaborator
|
do you intend to correct something else in this pr? |
Contributor
Author
No. I'll create separate Pull Request to add new spells in spellbook and cooldown groups. |
mehah
approved these changes
Jun 2, 2023
dudantas
pushed a commit
that referenced
this pull request
Nov 17, 2023
The Fear Condition is a status condition that makes the affected creature lose control of their movements for a short period of time. During this period, the affected creature randomly moves around in various directions, unable to perform any other actions. This condition is usually brought about by certain spells or monster effects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix spells cooldown if UINT16 is expected.
Fix by fusion32 from otland.
Behaviour
Actual
Same issue:
https://otland.net/threads/solved-otclient-lua-exception-attempt-to-index-local-spell-a-nil-value.284728/#post-2722382
https://otland.net/threads/help-request-spell-damage-causes-visual-bug-on-monster-death.284723/#post-2722327
Expected
Fixes
It is partialy resolve
# #527
Type of change
How Has This Been Tested
exurato test healing spells.exori visto test killing monsters with spellsTest Configuration:
Checklist