Skip to content

fix: UIWidget::setIcon crash#555

Merged
mehah merged 1 commit intoopentibiabr:mainfrom
Kamenuvol:patch-1
Jun 20, 2023
Merged

fix: UIWidget::setIcon crash#555
mehah merged 1 commit intoopentibiabr:mainfrom
Kamenuvol:patch-1

Conversation

@Kamenuvol
Copy link
Contributor

@Kamenuvol Kamenuvol commented Jun 20, 2023

From what I understand, you can't edit widget properties in mainDispatcher.

This fixed a random crash that was occurring in my custom client. I guess it could also occur here.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

From what i understand, you can't edit widget properties in mainDispatcher.

This fixed a random crash that was occurring in my custom client. I guess it could also occur here.
@mehah mehah changed the title Change thread for UIWidget::setIcon fix: UIWidget::setIcon crash Jun 20, 2023
@mehah mehah merged commit 2778b57 into opentibiabr:main Jun 20, 2023
dudantas pushed a commit that referenced this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants