feat: Opacity effect and missile in options#676
Merged
conde2 merged 8 commits intoopentibiabr:mainfrom Dec 13, 2023
kokekanon:main
Merged
feat: Opacity effect and missile in options#676conde2 merged 8 commits intoopentibiabr:mainfrom kokekanon:main
conde2 merged 8 commits intoopentibiabr:mainfrom
kokekanon:main
Conversation
issue of "roriscrave" in otland
Contributor
|
I think it should be |
OTC naming convention
conde2
suggested changes
Dec 11, 2023
csantbr
previously requested changes
Dec 13, 2023
Contributor
csantbr
left a comment
There was a problem hiding this comment.
I suggest keeping the OTUI spacing standard.
csantbr
reviewed
Dec 13, 2023
Co-authored-by: Caio Santoro dos Santos <61211407+csantbr@users.noreply.github.com>
conde2
approved these changes
Dec 13, 2023
Contributor
|
@csantbr this pull request can be approve, as soon as you approve it I will merge to main branch. |
conde2
approved these changes
Dec 13, 2023
All good now. Thanks for the review =)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue of "roriscrave" in otland https://otland.net/threads/need-otc-programmer-50u.287225/
PS: First time I make a PR
PS2: I don't know much about cpp, gesior gave the solution,

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Behaviour
Actual
Do this and that doesn't happens
Expected
Do this and that happens
Fixes
# (issue)
Type of change
How Has This Been Tested
Test Configuration:
Checklist
bandicam.2023-12-13.14-52-26-382.mp4