Skip to content

fix: artifact name conflict (windows)#716

Merged
mehah merged 1 commit intomainfrom
avoid-windows-artifact-name-conflict
Mar 8, 2024
Merged

fix: artifact name conflict (windows)#716
mehah merged 1 commit intomainfrom
avoid-windows-artifact-name-conflict

Conversation

@Costallat
Copy link
Copy Markdown
Contributor

Avoid artifact name conflict if we add a new windows version

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Behavior

Actual

Do this and that doesn't happens

Expected

Do this and that happens

Fixes

# (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version:
  • Client:
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Avoid artifact name conflict if we add a new windows version
@mehah mehah changed the title Update build-windows.yml fix: artifact name conflict (windows) Mar 8, 2024
@mehah mehah merged commit d64e260 into main Mar 8, 2024
@mehah mehah deleted the avoid-windows-artifact-name-conflict branch March 8, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants